I updated, and all of a sudden the prompt rendering is inconsistent

[apeir-n]

I just updated Homebrew, which updated to the latest version of OMP. Now, for some reason parts of my prompt are messed up, and change after I run commands. It seems like it's not properly rendering some of the segment variables, like the home icon I have set as a property of the .Path segment, or plain text segments. The first image below is how it's supposed to look, and the others are some examples of how it's rendering. There doesn't seem to be any rhyme or reason, like it doesn't depend on the directories I'm in or what commands I've run.

Here's the config, in case that helps:

console_title_template = '{{ .Folder }}'
version = 3

#  #e46876 #d27e99 #ffa066
[transient_prompt]
template = '󰜥   '
foreground = '#d27e99'
background = 'transparent'

[upgrade]
source = 'cdn'
interval = '168h'
auto = false
notice = false

[[blocks]]
type = 'prompt'
alignment = 'left'
newline = true

[[blocks.segments]]
leading_diamond = ''
trailing_diamond = ' '
template = '{{.Icon}}'
foreground = '#1F1F28'
background = '#938AA9'
type = 'os'
style = 'diamond'

[[blocks.segments]]
leading_diamond = ''
trailing_diamond = ' '
template = '  {{ .Name }}'
foreground = '#1F1F28'
background = '#7FB4CA'
type = 'shell'
style = 'diamond'

[[blocks.segments]]
leading_diamond = ''
trailing_diamond = ' '
template = ' ram: {{ round .PhysicalPercentUsed .Precision }}%'
foreground = '#1F1F28'
background = '#7AA89F'
type = 'sysinfo'
style = 'diamond'

[[blocks.segments]]
leading_diamond = ''
trailing_diamond = ''
template = ' {{ .FormattedMs }}'
foreground = '#1F1F28'
background = '#98BB6C'
type = 'executiontime'
style = 'diamond'

[blocks.segments.properties]
style = 'roundrock'
threshold = 0.0

[[blocks]]
type = 'prompt'
alignment = 'right'

[[blocks.segments]]
leading_diamond = ''
trailing_diamond = ''
template = '{{.UpstreamIcon }}{{ .HEAD }}{{if .BranchStatus }} {{ .BranchStatus }}{{ end }}{{ if .Working.Changed }}  {{ .Working.String }}{{ end }}{{ if and (.Working.Changed) (.Staging.Changed) }} |{{ end }}{{ if .Staging.Changed }}  {{ .Staging.String }}{{ end }}{{ if gt .StashCount 0 }}  {{ .StashCount }}{{ end }}'
foreground = '#1F1F28'
background = '#e46876'
type = 'git'
style = 'diamond'

[blocks.segments.properties]
branch_icon = ' '
fetch_stash_count = true
fetch_status = true
fetch_upstream_icon = true
fetch_worktree_count = true

[[blocks]]
type = 'prompt'
alignment = 'left'
newline = true

[[blocks.segments]]
template = '╭─'
type = 'text'
style = 'plain'

[[blocks.segments]]
template = '   {{ .CurrentDate | date .Format }} |'
type = 'time'
style = 'plain'

[blocks.segments.properties]
time_format = ' 03:04pm'

[[blocks.segments]]
template = '  '
type = 'root'
style = 'plain'

[[blocks.segments]]
template = ' {{ .Path }}'
type = 'path'
style = 'plain'

[blocks.segments.properties]
folder_icon = ' '
folder_separator_icon = '   '
home_icon = ' '

[[blocks]]
type = 'prompt'
alignment = 'left'
newline = true

[[blocks.segments]]
template = '╰─ '
type = 'status'
style = 'plain'

[blocks.segments.properties]
always_enabled = true

[onefish2]

I am seeing the same thing on macOS, Linux and Windows. This appears to be some kind of regression as this was working properly before 26.17.2

[JanDeDobbeleer]

@onefish2 @apeir-n I refactored templates, will have a look at this right away!

[JanDeDobbeleer]

The issue is inside this commit f3f8bc8, investigating.

[JanDeDobbeleer]

I found the issue, it's coming from this line and the change from a regular strings.Builder to our own text.StringBuilder pool object. As the builder is released on builder.String(), we end up putting it back on the pool for consumption, ending up in the broken state for our writer which causes a race condition effect. There's no need for this one to be a text.StringBuilder so I'm reverting that instance back to its original state.

[apeir-n]

Great! That fixed on my end.

[onefish2]

Thank you for the quick fix!!