Skip to content

Commit b727825

Browse files
authored
[automated] Merge branch 'vs17.14' => 'main' (dotnet#12393)
I detected changes in the vs17.14 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR. This PR merges commits made on vs17.14 by the following committers: * @JanProvaznik * @dotnet-maestro[bot] ## Instructions for merging from UI This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, *not* a squash or rebase commit. <img alt="merge button instructions" src="https://i.imgur.com/GepcNJV.png" width="300" /> If this repo does not allow creating merge commits from the GitHub UI, use command line instructions. ## Instructions for merging via command line Run these commands to merge this pull request from the command line. ``` sh git fetch git checkout vs17.14 git pull --ff-only git checkout main git pull --ff-only git merge --no-ff vs17.14 # If there are merge conflicts, resolve them and then run git merge --continue to complete the merge # Pushing the changes to the PR branch will re-trigger PR validation. git push https://github.com/dotnet/msbuild HEAD:merge/vs17.14-to-main ``` <details> <summary>or if you are using SSH</summary> ``` git push git@github.com:dotnet/msbuild HEAD:merge/vs17.14-to-main ``` </details> After PR checks are complete push the branch ``` git push ``` ## Instructions for resolving conflicts :warning: If there are merge conflicts, you will need to resolve them manually before merging. You can do this [using GitHub][resolve-github] or using the [command line][resolve-cli]. [resolve-github]: https://help.github.com/articles/resolving-a-merge-conflict-on-github/ [resolve-cli]: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ ## Instructions for updating this pull request Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.14-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged. The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote. ``` git fetch git checkout -b merge/vs17.14-to-main origin/main git pull https://github.com/dotnet/msbuild merge/vs17.14-to-main (make changes) git commit -m "Updated PR with my changes" git push https://github.com/dotnet/msbuild HEAD:merge/vs17.14-to-main ``` <details> <summary>or if you are using SSH</summary> ``` git fetch git checkout -b merge/vs17.14-to-main origin/main git pull git@github.com:dotnet/msbuild merge/vs17.14-to-main (make changes) git commit -m "Updated PR with my changes" git push git@github.com:dotnet/msbuild HEAD:merge/vs17.14-to-main ``` </details> Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues. Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
2 parents 53a2d6b + 65346c4 commit b727825

22 files changed

Lines changed: 46 additions & 32 deletions

.vsts-dotnet-ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ jobs:
8989
inputs:
9090
filename: 'eng/cibuild_bootstrapped_msbuild.cmd'
9191
arguments: -onlyDocChanged $(onlyDocChanged)
92+
env:
93+
ForceUseXCopyMSBuild: 1
9294
- task: PublishTestResults@2
9395
displayName: Publish .NET Framework Test Results
9496
inputs:
@@ -435,4 +437,4 @@ jobs:
435437
PathtoPublish: '$(Build.ArtifactStagingDirectory)/Verify'
436438
ArtifactName: 'macOS Verify $(System.JobAttempt)'
437439

438-
- template: /eng/common/templates/jobs/source-build.yml
440+
- template: /eng/common/templates/jobs/source-build.yml

.vsts-dotnet.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ parameters:
1414
displayName: Optional OptProfDrop Override
1515
type: string
1616
default: 'default'
17-
- name: EnableOptProf
17+
- name: enableOptProf
1818
displayName: Enable OptProf data collection for this build
1919
type: boolean
2020
default: true
@@ -42,7 +42,7 @@ variables:
4242
- name: SourceBranch
4343
value: ''
4444
# Override SkipApplyOptimizationData to true when disabling OptProf data collection
45-
- ${{ if eq(parameters.EnableOptProf, false) }}:
45+
- ${{ if eq(parameters.enableOptProf, false) }}:
4646
- name: SkipApplyOptimizationData
4747
value: true
4848
- name: EnableReleaseOneLocBuild
@@ -124,6 +124,7 @@ extends:
124124
parameters:
125125
isExperimental: false
126126
enableComponentGovernance: true
127+
enableOptProf: ${{ parameters.enableOptProf }}
127128

128129
- template: /eng/common/templates-official/post-build/post-build.yml@self
129130
parameters:

azure-pipelines/.vsts-dotnet-build-jobs.yml

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ parameters:
66
- name: enableComponentGovernance
77
type: boolean
88
default: false
9+
- name: enableOptProf
10+
type: boolean
11+
default: false
912

1013
jobs:
1114
- job: Windows_NT
@@ -70,6 +73,7 @@ jobs:
7073
AccessToken: '$(System.AccessToken)'
7174
feedSource: 'https://devdiv.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json'
7275
displayName: 'Install OptProf Plugin'
76+
condition: and(succeeded(), ${{ parameters.enableOptProf }})
7377

7478
# Required by MicroBuildBuildVSBootstrapper
7579
- task: MicroBuildSwixPlugin@4
@@ -106,7 +110,7 @@ jobs:
106110
toLowerCase: false
107111
usePat: true
108112
displayName: 'OptProf - Publish to Artifact Services - ProfilingInputs'
109-
condition: succeeded()
113+
condition: and(succeeded(), ${{ parameters.enableOptProf }})
110114

111115
# Build VS bootstrapper
112116
# Generates $(Build.StagingDirectory)\MicroBuild\Output\BootstrapperInfo.json
@@ -117,7 +121,7 @@ jobs:
117121
manifests: $(VisualStudio.SetupManifestList)
118122
outputFolder: '$(Build.SourcesDirectory)\artifacts\VSSetup\$(BuildConfiguration)\Insertion'
119123
displayName: 'OptProf - Build VS bootstrapper'
120-
condition: succeeded()
124+
condition: and(succeeded(), ${{ parameters.enableOptProf }})
121125

122126
# Publish run settings
123127
- task: PowerShell@2
@@ -129,7 +133,7 @@ jobs:
129133
/p:BootstrapperInfoPath=$(Build.StagingDirectory)\MicroBuild\Output\BootstrapperInfo.json
130134
/p:VisualStudioIbcTrainingSettingsPath=$(Build.SourcesDirectory)\eng\config\OptProf.runsettings
131135
displayName: 'OptProf - Build IBC training settings'
132-
condition: succeeded()
136+
condition: and(succeeded(), ${{ parameters.enableOptProf }})
133137

134138
# Publish bootstrapper info
135139
- task: 1ES.PublishBuildArtifacts@1
@@ -200,17 +204,18 @@ jobs:
200204
displayName: Tag build as ready for optimization training
201205
inputs:
202206
tags: 'ready-for-training'
203-
condition: succeeded()
207+
condition: and(succeeded(), ${{ parameters.enableOptProf }})
204208

205209
- task: ms-vseng.MicroBuildTasks.521a94ea-9e68-468a-8167-6dcf361ea776.MicroBuildCleanup@1
206210
displayName: Execute cleanup tasks
207211
condition: succeededOrFailed()
208212

209-
# Conditional component governance
210-
- ${{ if parameters.enableComponentGovernance }}:
211-
- template: /eng/common/templates-official/steps/component-governance.yml@self
212-
parameters:
213+
- template: /eng/common/templates-official/steps/component-governance.yml@self
214+
parameters:
215+
${{ if or(startsWith(variables['Build.SourceBranch'], 'refs/heads/vs'), eq(variables['Build.SourceBranch'], 'refs/heads/main')) }}:
213216
disableComponentGovernance: false
217+
${{ else }}:
218+
disableComponentGovernance: true
214219

215220
- template: /eng/common/templates-official/jobs/source-build.yml@self
216221
parameters:

azure-pipelines/.vsts-dotnet-exp-perf.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ parameters:
1818
displayName: Enable Signing Validation
1919
type: boolean
2020
default: false
21+
- name: enableOptProf
22+
displayName: Enable OptProf data collection for this build
23+
type: boolean
24+
default: false
2125

2226
variables:
2327
# if OptProfDrop is not set, string '$(OptProfDrop)' will be passed to the build script.
@@ -85,11 +89,12 @@ extends:
8589
parameters:
8690
isExperimental: true
8791
enableComponentGovernance: false
92+
enableOptProf: ${{ parameters.enableOptProf }}
8893

8994
- template: /eng/common/templates-official/post-build/post-build.yml@self
9095
parameters:
9196
publishingInfraVersion: 3
9297
enableSymbolValidation: true
9398
enableSourceLinkValidation: false
9499
enableNugetValidation: false
95-
enableSigningValidation: ${{ parameters.enableSigningValidation }}
100+
enableSigningValidation: ${{ parameters.enableSigningValidation }}

azure-pipelines/vs-insertion-experimental.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ parameters:
3333
- rel/d17.6
3434
- rel/d17.3
3535
- rel/d17.0
36-
36+
- rel/d16.11
37+
3738
variables:
3839
- name: TeamName
3940
value: msbuild

eng/Version.Details.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,4 @@
123123
<Sha>6122520523105dacdd702177a76c9f6b982fd759</Sha>
124124
</Dependency>
125125
</ToolsetDependencies>
126-
</Dependencies>
126+
</Dependencies>

eng/common/templates-official/steps/get-delegation-sas.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

eng/common/templates/steps/get-delegation-sas.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.cs.xlf

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Build/Resources/xlf/Strings.de.xlf

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)