Add the 'no-var' eslint rule for node files, replace them by let or const

Author: magopian

.eslintrc-node.js

@@ -17,6 +17,7 @@ module.exports = {
     "semi": ["error", "always"],
     "comma-dangle": ["error", "only-multiline"],
     "camelcase": "off",
+    "no-var": "error",
 
     // Override some eslint base rules because we're using node.
     "no-console": "off",

app.js

@@ -494,7 +494,7 @@ boot.executeInParallel([
     }
 
     let key = '';
-    var match;
+    let match;
     switch (data.name) {
       case 'cloud9':
         // Extract a valid SSH public key from the user's input.

lib/db.js

@@ -1,17 +1,17 @@
 // Copyright © 2016 Jan Keromnes. All rights reserved.
 // The following code is covered by the AGPL-3.0 license.
 
-var fs = require('fs');
+const fs = require('fs');
 
 // The datastore.
-var file = './db.json';
-var store = {};
+const file = './db.json';
+let store = {};
 load();
 
 // Load the datastore from disk synchronously.
 
 function load () {
-  var json = '{}';
+  let json = '{}';
 
   try {
     json = fs.readFileSync(file, 'utf8');
@@ -31,7 +31,7 @@ exports.load = load;
 // Save the datastore to disk asynchronously. TODO gzip?
 
 function save () {
-  var json = JSON.stringify(store, null, 2);
+  const json = JSON.stringify(store, null, 2);
 
   fs.writeFile(file, json + '\n', function (error) {
     if (error) {

lib/log.js

@@ -4,7 +4,7 @@
 // Log messages to the console with a timestamp.
 
 function log () {
-  var args = [].slice.call(arguments);
+  let args = [].slice.call(arguments);
   args.unshift('[' + new Date().toISOString() + ']');
 
   console.log.apply(console, args);

lib/streams.js

@@ -1,18 +1,18 @@
 // Copyright © 2016 Jan Keromnes. All rights reserved.
 // The following code is covered by the AGPL-3.0 license.
 
-var stream = require('stream');
+const stream = require('stream');
 
 const log = require('./log');
 
 // Streams that are currently in progress, per object.
-var objectStreams = new Map();
+let objectStreams = new Map();
 
 // Get `object[key]` as a stream (may still be receiving new data).
 
 function get (object, key) {
-  var passthrough = new stream.PassThrough();
-  var streams = objectStreams.get(object);
+  let passthrough = new stream.PassThrough();
+  let streams = objectStreams.get(object);
 
   if (object[key]) {
     passthrough.write(object[key], 'utf8');
@@ -32,7 +32,7 @@ exports.get = get;
 // Read a stream into `object[key]`.
 
 function set (object, key, readable) {
-  var streams = objectStreams.get(object);
+  let streams = objectStreams.get(object);
 
   if (!streams) {
     streams = {};
@@ -67,7 +67,7 @@ exports.set = set;
 // Remove any stream affected to `object[key]`.
 
 function remove (object, key) {
-  var streams = objectStreams.get(object);
+  let streams = objectStreams.get(object);
 
   // If the stream doesn't exist, do nothing.
   if (!streams || !streams[key]) {