test: add new page for both owncloud and opencloud

Author: anon-pradip

.github/workflows/ci.yml

@@ -102,16 +102,8 @@ jobs:
       - name: install-chromium
         run: npx playwright install chromium
 
-      - name: e2e (Opencloud)
-        if: matrix.server == 'Opencloud'
-        run: pnpm test:e2e tests/e2e/features/**/*.feature
-        env:
-          HEADLESS: true
-          TARGET_APP: opencloud
-
-      - name: e2e (Ocis)
-        if: matrix.server == 'Ocis'
+      - name: e2e-${{ matrix.server }}
         run: pnpm test:e2e tests/e2e/features/**/*.feature
         env:
           HEADLESS: true
-          TARGET_APP: ocis
+          TARGET_SERVER: matrix.server

README.md

@@ -106,7 +106,7 @@ pnpm run test:e2e <path_to_feature_file>
 
 For OpenCloud:
 ```bash
-TARGET_APP=opencloud pnpm run test:e2e <path_to_feature_file>
+TARGET_SERVER=opencloud pnpm run test:e2e <path_to_feature_file>
 ```
 
 ## Building Docker Container

tests/e2e/config.js

@@ -10,7 +10,7 @@ const config = {
   minTimeout: parseInt(process.env.MIN_TIMEOUT) || 5,
   headless: process.env.HEADLESS === 'true',
   debug: process.env.DEBUG === 'true',
-  targetApp: process.env.TARGET_APP || 'ocis'
+  targetServer: process.env.TARGET_SERVER.toLowerCase() || 'ocis'
 }
 
 module.exports = config

tests/e2e/pageObjects/FilesPage.js

@@ -0,0 +1,20 @@
+const Ocis = require('./OcisPage')
+const config = require('../config')
+
+class Files {
+  constructor() {
+    this.contextMenuBtnSelector = '.resource-table-btn-action-dropdown'
+    this.openInPresentationViewerBtnSelector = '.oc-files-actions-presentation-viewer-trigger'
+    this.openWithBtnSelector = 'button[id^="oc-files-context-actions-open-with-toggle"]'
+  }
+
+  async openMDFileInPresentationViewer() {
+    await page.click(this.contextMenuBtnSelector)
+    if (config.targetServer === 'opencloud') {
+      await page.click(this.openWithBtnSelector)
+    }
+    await page.click(this.openInPresentationViewerBtnSelector)
+  }
+}
+
+module.exports = Files

tests/e2e/pageObjects/OcisPage.js

@@ -22,11 +22,6 @@ class Ocis {
     await page.fill(this.passwordInputFieldSelector, password)
     await page.click(this.loginBtnSelector)
   }
-
-  async openMDFileInPresentationViewer() {
-    await page.click(this.contextMenuBtnSelector)
-    await page.click(this.openInPresentationViewerBtnSelector)
-  }
 }
 
 module.exports = Ocis

tests/e2e/pageObjects/OpencloudPage.js

@@ -1,16 +1,15 @@
 const { Given, When, Then } = require('@cucumber/cucumber')
 const { expect } = require('@playwright/test')
 
-const config = require('../config')
-
 const { getUserCredentials } = require('../utils/userHelper')
 const { uploadFile } = require('../utils/fileHelper')
 const PresentationViewer = require('../pageObjects/PresentationViewerPage')
 const Ocis = require('../pageObjects/OcisPage')
-const Opencloud = require('../pageObjects/OpencloudPage')
+const Files = require('../pageObjects/FilesPage')
 
 const presentationViewer = new PresentationViewer()
 const ocis = new Ocis()
+const files = new Files()
 
 Given(
   'user {string} has uploaded the markdown file {string} using API',
@@ -29,12 +28,7 @@ Given('user {string} has logged in', async function (user) {
 When(
   'user {string} previews a markdown file {string} in presentation viewer',
   async function (user, fileName) {
-    if (config.targetApp === 'opencloud') {
-      const opencloud = new Opencloud()
-      await opencloud.openMDFileInPresentationViewer()
-    } else {
-      await ocis.openMDFileInPresentationViewer()
-    }
+    await files.openMDFileInPresentationViewer()
   }
 )