Merge pull request #245 from JarvusInnovations/develop #32
themightychrisAnnotations
6 errors
|
publish-npm
Process completed with exit code 1.
|
|
src/sheet-nullish.test.ts > null/undefined-valued keys on write (#232) > a null array ELEMENT is rejected with the index named (not silently dropped):
packages/gitsheets/src/sheet-nullish.test.ts#L175
AssertionError: expected [Function] to throw error matching /array element \(index 1\)/ but got 'cannot marshal JS value of type Null …'
- Expected:
/array element \(index 1\)/
+ Received:
"cannot marshal JS value of type Null to a TOML value (null/undefined have no TOML representation)"
❯ src/sheet-nullish.test.ts:175:6
|
|
src/sheet-nullish.test.ts > null/undefined-valued keys on write (#232) > a required field set to null fails validation as missing (absent == null):
packages/gitsheets/src/sheet-nullish.test.ts#L158
AssertionError: expected Error: cannot marshal JS value of type Nu… { code: '…' } to be an instance of ValidationError
❯ src/sheet-nullish.test.ts:158:19
|
|
src/sheet-nullish.test.ts > null/undefined-valued keys on write (#232) > drops nullish keys recursively: nested tables and objects inside arrays:
packages/gitsheets/src/sheet.ts#L1710
Error: cannot marshal JS value of type Null to a TOML value (null/undefined have no TOML representation)
❯ src/sheet.ts:1710:17
❯ callCore src/core.ts:137:12
❯ Sheet.#upsertInTx src/sheet.ts:1709:23
❯ Repository.transact src/repository.ts:375:17
❯ src/sheet-nullish.test.ts:125:5
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'InvalidArg' }
|
|
src/sheet-nullish.test.ts > null/undefined-valued keys on write (#232) > writing the null-cleared record over the stripped record is a byte-level no-op (no new commit):
packages/gitsheets/src/sheet.ts#L1710
Error: cannot marshal JS value of type Null to a TOML value (null/undefined have no TOML representation)
❯ src/sheet.ts:1710:17
❯ callCore src/core.ts:137:12
❯ Sheet.#upsertInTx src/sheet.ts:1709:23
❯ Repository.transact src/repository.ts:375:17
❯ src/sheet-nullish.test.ts:115:20
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'InvalidArg' }
|
|
src/sheet-nullish.test.ts > null/undefined-valued keys on write (#232) > a Standard Schema validator emitting nulls for cleared optionals writes cleanly, with no trace in the bytes:
packages/gitsheets/src/validation.ts#L78
Error: cannot marshal JS value of type Undefined to a TOML value (null/undefined have no TOML representation)
❯ src/validation.ts:78:54
❯ callCore src/core.ts:137:12
❯ validateRecord src/validation.ts:78:33
❯ Sheet.upsert src/sheet.ts:1270:26
❯ src/sheet-nullish.test.ts:88:5
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'InvalidArg' }
|