Merge pull request #248 from JarvusInnovations/develop

Release: v2.3.1

Author: themightychris

package-lock.json

@@ -41,7 +41,7 @@
   "license": "Apache-2.0",
   "author": "Jarvus Innovations",
   "dependencies": {
-    "@gitsheets/core-napi": "^0.1.0",
+    "@gitsheets/core-napi": "^0.2.0",
     "csv-parse": "^6.2.1",
     "csv-stringify": "^6.7.0",
     "rfc6902": "^5.2.0",

packages/gitsheets/package.json

@@ -0,0 +1,42 @@
+---
+status: in-progress
+depends: []
+specs: []
+issues: []
+---
+
+# Ship @gitsheets/core-napi 0.2.0 and unblock the gitsheets npm release
+
+## Scope
+
+gitsheets v2.3.0's `publish-npm` failed: the workspace napi tests resolve platform binaries from the published `@gitsheets/core-napi` packages (optionalDependencies), which were still 0.1.x — predating #241's core marshal changes, whose tests assert the new error messages. Core changes require a core-napi release before a gitsheets release; this plan ships 0.2.0 and re-cuts the JS package as v2.3.1.
+
+## Implements
+
+Release engineering only; no spec changes.
+
+## Approach
+
+1. Bump only the consumer side: `packages/gitsheets` dep → `^0.2.0`. The napi package versions are **tag-stamped by the publish workflow** (`npm version $VERSION` from the tag name) and deliberately never committed — committing them breaks the stamp step ("Version not changed", learned the hard way on the first tag attempt).
+2. Tag `core-napi-v0.2.0` on develop (which carries the #241 core changes and the un-bumped 0.1.0 manifests) — the platform packages must exist on npm before the consumer-bump PR's `npm ci` can resolve.
+3. After publish: **sync the workspace manifests to the released version** (main + platform packages + optionalDeps — safe now; stamping only fails when the committed version equals the tag being stamped) and refresh `package-lock.json` against the live 0.2.0 packages, then merge. Without the sync, workspace tests keep resolving the previous platform binaries.
+4. Re-run the release flow as v2.3.1 (v2.3.0's GitHub release exists; its npm publish never landed — v2.3.1 is the npm release of the same content).
+
+## Validation
+
+- [ ] @gitsheets/core-napi 0.2.0 (+6 platform packages) live on npm
+- [x] Local fresh linux-x64-gnu build passes the 108-test napi suite
+- [ ] PR CI green with lockfile resolving 0.2.0
+- [ ] gitsheets 2.3.1 on npm; `publish-npm` green
+
+## Risks / unknowns
+
+- Trusted-publishing config must already cover all 7 packages (bootstrapped at 0.1.0; assumed intact).
+
+## Notes
+
+Lesson: core-behavior changes must bump/release core-napi in the same batch as the consuming JS release.
+
+## Follow-ups
+
+- Consider a CI guard: fail fast with a clear "release core-napi first" message when workspace napi tests would resolve platform binaries older than the workspace core, instead of a mid-publish test failure.

plans/core-napi-0.2.0-release.md

@@ -1,6 +1,6 @@
 {
   "name": "@gitsheets/core-napi-darwin-arm64",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "os": [
     "darwin"
   ],

rust/gitsheets-napi/npm/darwin-arm64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitsheets/core-napi-darwin-x64",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "os": [
     "darwin"
   ],

rust/gitsheets-napi/npm/darwin-x64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitsheets/core-napi-linux-arm64-gnu",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "os": [
     "linux"
   ],

rust/gitsheets-napi/npm/linux-arm64-gnu/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitsheets/core-napi-linux-x64-gnu",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "os": [
     "linux"
   ],

rust/gitsheets-napi/npm/linux-x64-gnu/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitsheets/core-napi-linux-x64-musl",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "os": [
     "linux"
   ],

rust/gitsheets-napi/npm/linux-x64-musl/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gitsheets/core-napi-win32-x64-msvc",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "os": [
     "win32"
   ],

rust/gitsheets-napi/npm/win32-x64-msvc/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@gitsheets/core-napi",
-  "version": "0.1.0",
-  "description": "Node.js native binding for gitsheets-core — the FFI marshalling boundary.",
+  "version": "0.2.0",
+  "description": "Node.js native binding for gitsheets-core \u2014 the FFI marshalling boundary.",
   "main": "binding.cjs",
   "types": "index.d.ts",
   "license": "Apache-2.0",
@@ -33,12 +33,12 @@
     "index.d.ts"
   ],
   "optionalDependencies": {
-    "@gitsheets/core-napi-linux-x64-gnu": "0.1.0",
-    "@gitsheets/core-napi-linux-arm64-gnu": "0.1.0",
-    "@gitsheets/core-napi-linux-x64-musl": "0.1.0",
-    "@gitsheets/core-napi-darwin-arm64": "0.1.0",
-    "@gitsheets/core-napi-darwin-x64": "0.1.0",
-    "@gitsheets/core-napi-win32-x64-msvc": "0.1.0"
+    "@gitsheets/core-napi-linux-x64-gnu": "0.2.0",
+    "@gitsheets/core-napi-linux-arm64-gnu": "0.2.0",
+    "@gitsheets/core-napi-linux-x64-musl": "0.2.0",
+    "@gitsheets/core-napi-darwin-arm64": "0.2.0",
+    "@gitsheets/core-napi-darwin-x64": "0.2.0",
+    "@gitsheets/core-napi-win32-x64-msvc": "0.2.0"
   },
   "scripts": {
     "artifacts": "napi artifacts",