Skip to content

Commit e5a3258

Browse files
fix: remove scope-manager dep
1 parent 1daf2ff commit e5a3258

File tree

5 files changed

+3
-31
lines changed

5 files changed

+3
-31
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
"typecheck": "tsc --noEmit"
5353
},
5454
"dependencies": {
55-
"@typescript-eslint/scope-manager": "^8.56.0",
5655
"@typescript-eslint/utils": "^8.56.0",
5756
"decamelize": "^6.0.1",
5857
"ts-api-utils": "^2.4.0",

src/etc/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@ export * from './could-be-type';
33
export * from './find-parent';
44
export * from './get-loc';
55
export * from './get-type-services';
6-
export * from './is-import';
76
export * from './is';

src/etc/is-import.ts

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/rules/no-ignored-takewhile-value.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { TSESTree as es } from '@typescript-eslint/utils';
22
import {
33
isArrayPattern,
44
isIdentifier,
5-
isImport,
65
isObjectPattern,
76
} from '../etc';
87
import { ruleCreator } from '../utils';
@@ -25,9 +24,6 @@ export const noIgnoredTakewhileValueRule = ruleCreator({
2524
expression: es.ArrowFunctionExpression | es.FunctionExpression,
2625
) {
2726
const scope = context.sourceCode.getScope(expression);
28-
if (!isImport(scope, 'takeWhile', /^rxjs\/?/)) {
29-
return;
30-
}
3127
let ignored = true;
3228
const [param] = expression.params;
3329
if (param) {
@@ -53,10 +49,10 @@ export const noIgnoredTakewhileValueRule = ruleCreator({
5349
}
5450

5551
return {
56-
'CallExpression[callee.name=\'takeWhile\'] > ArrowFunctionExpression': (
52+
'CallExpression[callee.property.name=\'pipe\'] > CallExpression[callee.name=\'takeWhile\'] > ArrowFunctionExpression': (
5753
node: es.ArrowFunctionExpression,
5854
) => { checkNode(node); },
59-
'CallExpression[callee.name=\'takeWhile\'] > FunctionExpression': (
55+
'CallExpression[callee.property.name=\'pipe\'] > CallExpression[callee.name=\'takeWhile\'] > FunctionExpression': (
6056
node: es.FunctionExpression,
6157
) => { checkNode(node); },
6258
};

yarn.lock

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,7 @@ __metadata:
862862
languageName: node
863863
linkType: hard
864864

865-
"@typescript-eslint/scope-manager@npm:8.56.0, @typescript-eslint/scope-manager@npm:^8.55.0, @typescript-eslint/scope-manager@npm:^8.56.0":
865+
"@typescript-eslint/scope-manager@npm:8.56.0, @typescript-eslint/scope-manager@npm:^8.55.0":
866866
version: 8.56.0
867867
resolution: "@typescript-eslint/scope-manager@npm:8.56.0"
868868
dependencies:
@@ -1987,7 +1987,6 @@ __metadata:
19871987
"@types/common-tags": "npm:^1.8.4"
19881988
"@types/node": "npm:~20.19.33"
19891989
"@typescript-eslint/rule-tester": "npm:^8.56.0"
1990-
"@typescript-eslint/scope-manager": "npm:^8.56.0"
19911990
"@typescript-eslint/utils": "npm:^8.56.0"
19921991
"@typescript/vfs": "npm:^1.6.3"
19931992
"@vitest/coverage-v8": "npm:^4.0.18"

0 commit comments

Comments
 (0)