More configure await in EF Core generated code, fixed new idempotency tests. Closes GH-2042

Author: jeremydmiller

src/Persistence/EfCoreTests/idempotency_with_inline_or_buffered_endpoints_end_to_end.cs

@@ -1,6 +1,7 @@
 using IntegrationTests;
 using JasperFx;
 using JasperFx.CodeGeneration.Frames;
+using JasperFx.Core;
 using JasperFx.Resources;
 using Marten;
 using Microsoft.Data.SqlClient;
@@ -162,6 +163,8 @@ public async Task apply_idempotency_to_non_transactional_handler()
         using var host = await Host.CreateDefaultBuilder()
             .UseWolverine(opts =>
             {
+                opts.Durability.Mode = DurabilityMode.Solo;
+                
                 opts.Services.AddDbContextWithWolverineIntegration<CleanDbContext>(x =>
                     x.UseSqlServer(Servers.SqlServerConnectionString));
 
@@ -194,6 +197,7 @@ public async Task apply_idempotency_to_non_transactional_handler()
 
         var tracked2 = await host.TrackActivity()
             .DoNotAssertOnExceptionsDetected()
+            .Timeout(15.Seconds())
             .ExecuteAndWaitAsync(c =>
             {
                 sentMessage.WasPersistedInInbox = false;

src/Persistence/Wolverine.EntityFrameworkCore/Codegen/EnrollDbContextInTransaction.cs

@@ -37,25 +37,25 @@ public override void GenerateCode(GeneratedMethod method, ISourceWriter writer)
             "Enroll the DbContext & IMessagingContext in the outgoing Wolverine outbox transaction");
         writer.Write($"var {_envelopeTransaction.Usage} = new {typeof(EfCoreEnvelopeTransaction).FullNameInCode()}({_dbContext.Usage}, {_context.Usage}, {_scrapers.Usage});");
         writer.Write(
-            $"await {_context.Usage}.{nameof(MessageContext.EnlistInOutboxAsync)}({_envelopeTransaction.Usage});");
+            $"await {_context.Usage}.{nameof(MessageContext.EnlistInOutboxAsync)}({_envelopeTransaction.Usage}).ConfigureAwait(false);");
 
 
         writer.WriteComment("Start the actual database transaction");
-        writer.Write($"using var {Transaction.Usage} = await {_dbContext.Usage}.Database.BeginTransactionAsync({_cancellation.Usage});");
+        writer.Write($"using var {Transaction.Usage} = await {_dbContext.Usage}.Database.BeginTransactionAsync({_cancellation.Usage}).ConfigureAwait(false);");
         writer.Write("BLOCK:try");
 
         // EF Core can only do eager idempotent checks
         if (_idempotencyStyle == IdempotencyStyle.Eager || _idempotencyStyle == IdempotencyStyle.Optimistic)
         {
-            writer.Write($"await {_context.Usage}.{nameof(MessageContext.AssertEagerIdempotencyAsync)}({_cancellation.Usage});");
+            writer.Write($"await {_context.Usage}.{nameof(MessageContext.AssertEagerIdempotencyAsync)}({_cancellation.Usage}).ConfigureAwait(false);");
         }
 
         Next?.GenerateCode(method, writer);
 
-        writer.Write($"await {_envelopeTransaction.Usage}.CommitAsync({_cancellation.Usage});");
+        writer.Write($"await {_envelopeTransaction.Usage}.CommitAsync({_cancellation.Usage}).ConfigureAwait(false);");
         writer.FinishBlock();
         writer.Write($"BLOCK:catch ({typeof(Exception).FullNameInCode()})");
-        writer.Write($"await {_envelopeTransaction.Usage}.RollbackAsync();");
+        writer.Write($"await {_envelopeTransaction.Usage}.RollbackAsync().ConfigureAwait(false);");
         writer.Write("throw;");
         writer.FinishBlock();
     }

src/Wolverine/Runtime/MessageContext.cs

@@ -80,7 +80,7 @@ private bool isMissingRequestedReply()
     public async Task AssertEagerIdempotencyAsync(CancellationToken cancellation)
     {
         if (Envelope == null || Envelope.WasPersistedInInbox ) return;
-        if (Transaction == null)
+        if (Transaction == null || Transaction is MessageContext)
         {
             var exists = await Runtime.Storage.Inbox.ExistsAsync(Envelope, cancellation);
             if (exists)