- Added tests for the media controller

Signed-off-by: Arushad Ahmed <[email protected]>

Author: dash8x

tests/Feature/Controllers/MediaControllerTest.php

@@ -115,5 +115,85 @@ public function it_can_upload_a_file_to_the_media_library_and_return_json(): voi
         ]);
     }
 
+    #[Test]
+    public function it_does_not_allow_viewing_media_index_page_for_unauthorized_users(): void
+    {
+        Gate::define('view_media', function (User $user) {
+            return false;
+        });
+
+        $user = User::factory()->create();
+
+        $this->actingAs($user);
+
+        $media = $this->getMedia(user: $user);
+
+        $this->get('/media')
+            ->assertStatus(403)
+            ->assertDontSee($media->name);
+    }
+
+    #[Test]
+    public function it_does_not_show_other_users_media_to_unauthorized_users_on_the_index_page(): void
+    {
+        $this->withoutExceptionHandling();
+
+        Gate::define('view_media', function (User $user) {
+            return true;
+        });
+
+        Gate::define('view_others_media', function (User $user) {
+            return false;
+        });
+
+        $user = User::factory()->create();
+
+        $this->actingAs($user);
+
+        $media = $this->getMedia(user: $user);
+
+        $other_user = User::factory()->create();
+
+
+        $other_file = $this->getTestImageEndingWithUnderscore();
+        $other_media = $this->getMedia($other_file, user: $other_user);
+
+        $this->get('/media')
+            ->assertSuccessful()
+            ->assertDontSee($other_media->name)
+            ->assertSee($media->name);
+    }
+
+    #[Test]
+    public function it_can_show_others_media_to_authorized_users_on_the_index_page(): void
+    {
+        $this->withoutExceptionHandling();
+
+        Gate::define('view_media', function (User $user) {
+            return true;
+        });
+
+        Gate::define('view_others_media', function (User $user) {
+            return true;
+        });
+
+        $user = User::factory()->create();
+
+        $this->actingAs($user);
+
+        $media = $this->getMedia(user: $user);
+
+        $other_user = User::factory()->create();
+
+
+        $other_file = $this->getTestImageEndingWithUnderscore();
+        $other_media = $this->getMedia($other_file, user: $other_user);
+
+        $this->get('/media')
+            ->assertSuccessful()
+            ->assertSee($other_media->name)
+            ->assertSee($media->name);
+    }
+
 
 }

tests/TestCase.php

@@ -7,6 +7,7 @@
 use Illuminate\Support\Facades\Artisan;
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Facades\View;
+use Javaabu\Forms\FormsServiceProvider;
 use Javaabu\Helpers\HelpersServiceProvider;
 use Javaabu\Mediapicker\Models\Attachment;
 use Javaabu\Mediapicker\Tests\TestSupport\Models\ModelWithConversions;
@@ -61,6 +62,7 @@ protected function getPackageProviders($app)
             TestServiceProvider::class,
             HelpersServiceProvider::class,
             SettingsServiceProvider::class,
+            FormsServiceProvider::class,
             ActivitylogServiceProvider::class,
         ];
     }
@@ -96,16 +98,18 @@ protected function getImageDimensions(string $path): array
         return compact('width', 'height');
     }
 
-    protected function getUserWithMedia(string $file = '', string $name = ''): User
+    protected function getUserWithMedia(string $file = '', string $name = '', ?User $user = null): User
     {
         if (! $file) {
             $file = $this->getTestJpg();
         }
 
-        /** @var User $user */
-        $user = User::factory()->create([
-            'name' => $name ?: fake()->name,
-        ]);
+        if (! $user) {
+            /** @var User $user */
+            $user = User::factory()->create([
+                'name' => $name ?: fake()->name,
+            ]);
+        }
 
         $user->addMedia($file)
             ->preservingOriginal()
@@ -114,13 +118,13 @@ protected function getUserWithMedia(string $file = '', string $name = ''): User
         return $user;
     }
 
-    protected function getMedia(string $file = ''): Media
+    protected function getMedia(string $file = '', ?User $user = null): Media
     {
         if (! $file) {
             $file = $this->getTestJpg();
         }
 
-        $user = $this->getUserWithMedia($file);
+        $user = $this->getUserWithMedia($file, user: $user);
 
         return $user->getFirstMedia('mediapicker');
     }

tests/TestSupport/views/layouts/admin.blade.php

@@ -0,0 +1,25 @@
+<!doctype html>
+<html lang="{{ str_replace('_', '-', app()->getLocale()) }}">
+@section('title', 'Admin')
+
+<body>
+<main class="main">
+
+
+    <!-- Contents -->
+    <section class="content">
+        <header class="content__title">
+            <h1>@yield('page-title')</h1>
+            @yield('page-subheading')
+            {{--<small>Sub heading contents</small>--}}
+            @yield('model-actions')
+        </header>
+
+        @section('content')
+        @show
+    </section>
+</main>
+
+@stack('scripts')
+</body>
+</html>