Bump actions/upload-pages-artifact from 4 to 5 #721

Workflow file for this run

.github/workflows/build-lcg-cvmfs.yml at 8ee1df2

	---
	name: Build LCG on CVMFS

	on:
	push:
	branches: [ main ]
	pull_request:

	concurrency:
	group: ${{ github.workflow }}-${{ github.event.pull_request.number \|\| github.run_id }}
	cancel-in-progress: true

	jobs:
	linux:
	runs-on: ubuntu-24.04
	strategy:
	fail-fast: false
	matrix:
	include:
	# Standard builds without sanitizers
	- release: "LCG_106"
	arch: "x86_64"
	os: "el9"
	compiler: "gcc13"
	opt: "opt"
	cxxflags: "-march=x86-64-v3 -mtune=generic -g -pg"
	submodules: true
	- release: "LCG_107"
	arch: "x86_64"
	os: "el9"
	compiler: "gcc14"
	opt: "opt"
	cxxflags: "-march=x86-64-v3 -mtune=generic"
	submodules: true
	- release: "LCG_108"
	arch: "x86_64"
	os: "el9"
	compiler: "clang19"
	opt: "opt"
	cxxflags: "-march=x86-64-v3 -mtune=generic"
	submodules: true
	- release: "LCG_108"
	arch: "x86_64"
	os: "el9"
	compiler: "gcc15"
	opt: "opt"
	cxxflags: "-march=x86-64-v3 -mtune=generic"
	submodules: true
	# Build without submodules
	- release: "LCG_108"
	arch: "x86_64"
	os: "el9"
	compiler: "gcc15"
	opt: "dbg"
	cxxflags: "-march=x86-64-v3 -mtune=generic"
	submodules: false
	steps:
	- uses: actions/checkout@v6
	with:
	submodules: ${{ matrix.submodules }}
	fetch-depth: 0
	- uses: cvmfs-contrib/github-action-cvmfs@v5
	with:
	cvmfs_repositories: 'sft.cern.ch,geant4.cern.ch'
	- name: Install ccache
	run: \|
	sudo apt-get update
	sudo apt-get install -y ccache
	- name: Setup ccache cache
	uses: actions/cache@v5
	with:
	path: ~/.ccache
	key: ccache-${{ matrix.LCG }}-${{ github.ref_name }}
	restore-keys: \|
	ccache-${{ matrix.LCG }}-
	ccache-
	- name: Configure ccache
	run: \|
	ccache --set-config=cache_dir=$HOME/.ccache
	ccache --set-config=max_size=1G
	ccache --set-config=compression=true
	ccache --zero-stats
	echo "PATH=/usr/lib/ccache:$PATH" >> $GITHUB_ENV
	- uses: aidasoft/run-lcg-view@v5
	with:
	release-platform: ${{ matrix.release }}/${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	run: \|
	echo "::group::Add submodules to git safe directories"
	git config --global --add safe.directory $PWD
	git config --global --add safe.directory $PWD/thirdparty/\* # Literal asterisk
	git config --global --get-all safe.directory
	echo "::endgroup"

	echo "::group::Dependencies"
	# Install dependencies
	PYTHONHOME="" PYTHONPATH="" dnf install -y time
	# Sqlpp23 requires pyparsing>=3
	pip install 'pyparsing>=3'
	for i in $HOME/.local/lib/python* ; do
	export PYTHONPATH=$i/site-packages:$PYTHONPATH
	done
	echo "::endgroup::"

	echo "::group::Configuration"
	# Set BOOST_INC_DIR and BOOST_LIB_DIR to point to
	# LCG-provided Boost installation
	LCG_PATH="/cvmfs/sft.cern.ch/lcg/views/${{ matrix.release }}/${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}"
	export BOOST_INC_DIR="${LCG_PATH}/include"
	export BOOST_LIB_DIR="${LCG_PATH}/lib"

	# Generate setup scripts
	chmod +x SetupFiles/make_SET_ME_UP
	SetupFiles/make_SET_ME_UP
	echo "::endgroup::"

	echo "::group::System architecture"
	gcc -march=native -Q --help=target \| grep -m1 -- '-march='
	echo "::endgroup::"

	echo "::group::Compilation with ccache"
	if [[ "${{ matrix.submodules }}" == "true" ]] ; then
	SQLPP_OPTIONS="\
	-DBUILD_MARIADB_CONNECTOR=ON \
	-DBUILD_MYSQL_CONNECTOR=ON \
	-DBUILD_POSTGRESQL_CONNECTOR=ON \
	-DBUILD_SQLITE3_CONNECTOR=ON"
	else
	SQLPP_OPTIONS=""
	fi
	cmake -Bbuild -S. \
	-Wdev -Werror=dev \
	${SQLPP_OPTIONS} \
	-DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_C_COMPILER_LAUNCHER=ccache \
	-DCMAKE_INSTALL_PREFIX=install \
	-DCMAKE_CXX_FLAGS="${{ matrix.cxxflags }}" 2>&1 \| tee cmake.txt
	# Check the log file for unused variables
	if grep -q "Manually-specified variables were not used" cmake.txt; then
	echo "ERROR: Unused CMake variables detected."
	exit 1
	fi
	cmake --build build -j$(nproc) --target install
	echo "::endgroup::"

	echo "::group::ccache statistics"
	ccache --show-stats
	echo "::endgroup::"

	# Ensure we fail even when piping output to tee
	set -o pipefail

	echo "::group::Mock data generation"
	# Run the mock data generator and analysis as described in README
	source SetupFiles/SET_ME_UP.bash

	# Generate mock data
	/usr/bin/time -v \
	build/qwmockdatagenerator -r 4 -e 1:20000 \
	--config qwparity_simple.conf \
	--detectors mock_newdets.map \
	--data . \| tee qwmockdataenerator.log
	echo "::endgroup::"

	echo "::group::Create database (sqlite3)"
	# Create and populate the database
	# (sqlite3 only supports INTEGER PRIMARY KEY, not INT UNSIGNED or TINYINT UNSIGNED)
	# (sqlite3 does not support ENUM, so convert to TEXT with CHECK)
	sed -e 's/INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY/INTEGER PRIMARY KEY/g' \
	-e 's/TINYINT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY/INTEGER PRIMARY KEY/g' \
	-e 's/$\S$\sENUM($[^)]$)/\1 TEXT CHECK(\1 in (\2))/g' \
	Parity/prminput/qwparity_schema.sql \| sqlite3 qwparity.db
	# Insert dummy schema version (compare with QwParityDB.h)
	sqlite3 qwparity.db "INSERT INTO db_schema VALUES(0, '01','04','0000','1970-01-01 00:00:00.000','build-lcg-cvmfs.yml');"
	# Insert dummy seed data
	sqlite3 qwparity.db "INSERT INTO seeds VALUES(0, 0, 10, 'foo', 'bar');"
	echo "::endgroup::"

	echo "::group::Mock data analysis (sqlite3, trees)"
	# Analyze the generated mock data
	mkdir -p trees
	/usr/bin/time -v \
	build/qwparity -r 4 \
	--config qwparity_simple.conf \
	--detectors mock_newdets.map \
	--datahandlers mock_datahandlers.map \
	--data . \
	--rootfiles trees/. \
	--write-promptsummary \
	--QwDatabase.accesslevel RW \
	--QwDatabase.dbtype sqlite3 \
	--QwDatabase.dbname qwparity.db \| tee qwparity-trees.log
	echo "::endgroup::"

	if printf "%s\n%s" 6.36.00 $(root-config --version) \| sort -V -C ; then
	echo "::group::Mock data analysis (sqlite3, rntuples)"
	# Analyze the generated mock data
	mkdir -p rntuples
	/usr/bin/time -v \
	build/qwparity -r 4 \
	--config qwparity_simple.conf \
	--detectors mock_newdets.map \
	--datahandlers mock_datahandlers.map \
	--data . \
	--rootfiles rntuples/. \
	--write-promptsummary \
	--QwDatabase.accesslevel RW \
	--QwDatabase.dbtype sqlite3 \
	--QwDatabase.dbname qwparity.db \
	--enable-rntuples \
	--disable-trees \| tee qwparity-rntuples.log
	echo "::endgroup::"
	fi

	echo "::group::Print database contents (sqlite3)"
	# Print the database contents
	sqlite3 qwparity.db .dump \| tee qwparity-sqlite3.sql
	echo "::endgroup::"

	echo "::group:: Profile analysis"
	if [ -f gmon.out ] ; then
	gprof build/qwparity \| tee qwparity-profile.txt
	fi
	echo "::endgroup::"

	- name: Compress build directory
	run: tar -caf build.tar.zst build/
	- name: Upload build artifact
	uses: actions/upload-artifact@v7
	with:
	name: build-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: build.tar.zst
	retention-days: 7
	if-no-files-found: error

	- name: Upload logs
	uses: actions/upload-artifact@v7
	with:
	name: logs-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: \|
	qwmockdatagenerator.log
	qwparity-*.log
	retention-days: 7
	if-no-files-found: ignore

	- name: Upload profiling analysis
	uses: actions/upload-artifact@v7
	with:
	name: gprof-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: \|
	qwparity-profile.txt
	retention-days: 7
	if-no-files-found: ignore

	- name: Upload prompt summary
	uses: actions/upload-artifact@v7
	with:
	name: prompt-summary-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: \|
	trees/summary_*.txt
	rntuples/summary_*.txt
	retention-days: 7
	if-no-files-found: error

	- name: Upload database dumps
	uses: actions/upload-artifact@v7
	with:
	name: qwparity-sql-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: \|
	qwparity-*.sql
	retention-days: 7
	if-no-files-found: error

	- name: Upload regression alias definitions
	uses: actions/upload-artifact@v7
	with:
	name: regalias-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: \|
	regalias.C
	retention-days: 7
	if-no-files-found: error

	- name: Download target branch artifacts (prompt summary)
	if: github.event_name == 'pull_request'
	uses: dawidd6/action-download-artifact@v20
	with:
	workflow: build-lcg-cvmfs.yml
	branch: ${{ github.event.pull_request.base.ref }}
	name: prompt-summary-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: ./target
	if_no_artifact_found: warn

	- name: Download target branch artifacts (regalias)
	if: github.event_name == 'pull_request'
	uses: dawidd6/action-download-artifact@v20
	with:
	workflow: build-lcg-cvmfs.yml
	branch: ${{ github.event.pull_request.base.ref }}
	name: regalias-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: ./target
	if_no_artifact_found: warn

	- name: Compare artifacts
	if: github.event_name == 'pull_request'
	run: \|
	echo "Comparing artifacts for ${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}"

	# Check if target artifacts exist
	if [ ! -d "./target" ] \|\| [ -z "$(ls -A ./target)" ]; then
	echo "⚠️ No target branch artifacts found. This may be the first run or target branch hasn't been built recently."
	echo "Skipping comparison for this configuration."
	exit 0
	fi

	# Find summary files in both directories
	current_files=$(find ./ ./trees ./rntuples -maxdepth 1 -name "summary_.txt" -o -name "regalias*.C" \| sort)
	target_files=$(find ./target -name "summary_.txt" -o -name "regalias*.C" \| sort)

	echo "Current files found:"
	echo "$current_files"
	echo "Target files found:"
	echo "$target_files"

	# Compare each file
	comparison_failed=false
	for current_file in $current_files; do
	filename=$(basename "$current_file")
	if [ -f ./target/$current_file ]; then
	target_file="./target/$current_file"
	else
	target_file="./target/$filename"
	fi

	if [ ! -f "$target_file" ]; then
	echo "❌ Target file $current_file not found"
	comparison_failed=true
	continue
	fi

	echo "Comparing $current_file..."

	# Skip lines containing timestamps and metadata that can vary
	if diff -q <(grep -v "Start Time:\\|End Time:" "$current_file") <(grep -v "Start Time:\\|End Time:" "$target_file") > /dev/null; then
	echo "✅ $current_file: No meaningful differences found"
	else
	echo "❌ $current_file: Differences found beyond timestamps"
	echo "--- Expected (target branch) ---"
	grep -v "Start Time:\\|End Time:" "$target_file" \| cat
	echo "--- Actual (current PR) ---"
	grep -v "Start Time:\\|End Time:" "$current_file" \| cat
	echo "--- Detailed diff ---"
	diff -u <(grep -v "Start Time:\\|End Time:" "$target_file") <(grep -v "Start Time:\\|End Time:" "$current_file") \| cat
	comparison_failed=true
	fi
	done

	if [ "$comparison_failed" = "true" ]; then
	echo "❌ Artifact comparison failed. Changes detected in artifacts beyond timestamps."
	exit 1
	else
	echo "✅ All artifacts match expected results (ignoring timestamps)."
	fi


	valgrind:
	runs-on: ubuntu-latest
	needs: linux
	strategy:
	fail-fast: false
	matrix:
	include:
	- release: "LCG_107"
	arch: "x86_64"
	os: "el9"
	compiler: "gcc14"
	opt: "opt"
	cxxflags: ""
	steps:
	- uses: actions/checkout@v6

	- name: Download build artifact
	uses: actions/download-artifact@v8
	with:
	name: build-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: .
	- name: Uncompress build artifact
	run: tar -xaf build.tar.zst

	- uses: cvmfs-contrib/github-action-cvmfs@v5
	with:
	cvmfs_repositories: 'sft.cern.ch,geant4.cern.ch'
	- uses: aidasoft/run-lcg-view@v5
	with:
	release-platform: ${{ matrix.release }}/${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	run: \|
	echo "::group::System architecture"
	gcc -march=native -Q --help=target \| grep -m1 -- '-march='
	echo "::endgroup::"

	# Ensure we fail even when piping output to tee
	set -o pipefail

	echo "::group::Mock data generation"
	build/qwmockdatagenerator -r 4 -e 1:20000 --config qwparity_simple.conf --detectors mock_newdets.map --data .
	echo "::endgroup::"

	echo "::group::Run callgrind on mock data analysis (no rntuples, no trees, no hists)"
	valgrind --tool=callgrind --callgrind-out-file=callgrind.out.no-out --instr-atstart=no \
	build/qwparity -r 4 --config qwparity_simple.conf --detectors mock_newdets.map --datahandlers mock_datahandlers.map --data . --rootfiles . --write-promptsummary --callgrind-instr-start-event-loop \
	--disable-trees --disable-histos
	echo "::endgroup::"

	echo "::group::Annotate callgrind info on source code (no rntuples, no trees, no hists)"
	callgrind_annotate \
	-I=Parity/src/ -I=Parity/include -I=Analysis/src -I=Analysis/include \
	callgrind.out.no-out Parity/main/QwParity.cc \| tee -a callgrind-no-out.txt
	echo "::endgroup::"

	echo "::group::Run callgrind on mock data analysis (trees, hists)"
	valgrind --tool=callgrind --callgrind-out-file=callgrind.out.trees --instr-atstart=no \
	build/qwparity -r 4 --config qwparity_simple.conf --detectors mock_newdets.map --datahandlers mock_datahandlers.map --data . --rootfiles . --write-promptsummary --callgrind-instr-start-event-loop
	echo "::endgroup::"

	echo "::group::Annotate callgrind info on source code (trees, hists)"
	callgrind_annotate \
	-I=Parity/src/ -I=Parity/include -I=Analysis/src -I=Analysis/include \
	callgrind.out.trees Parity/main/QwParity.cc \| tee -a callgrind-trees.txt
	echo "::endgroup::"

	echo "::group::Run callgrind on mock data analysis (rntuples, hists)"
	valgrind --tool=callgrind --callgrind-out-file=callgrind.out.rntuples --instr-atstart=no \
	build/qwparity -r 4 --config qwparity_simple.conf --detectors mock_newdets.map --datahandlers mock_datahandlers.map --data . --rootfiles . --write-promptsummary --callgrind-instr-start-event-loop \
	--enable-rntuples --disable-trees
	echo "::endgroup::"

	echo "::group::Annotate callgrind info on source code (rntuples, hists)"
	callgrind_annotate \
	-I=Parity/src/ -I=Parity/include -I=Analysis/src -I=Analysis/include \
	callgrind.out.rntuples Parity/main/QwParity.cc \| tee -a callgrind-rntuples.txt
	echo "::endgroup::"

	- name: Upload callgrind analysis
	uses: actions/upload-artifact@v7
	with:
	name: callgrind-${{ matrix.release }}-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.opt }}
	path: \|
	callgrind*.txt
	retention-days: 7
	if-no-files-found: error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump actions/upload-pages-artifact from 4 to 5 #721

Workflow file

Bump actions/upload-pages-artifact from 4 to 5 #721

Uh oh!

Workflow file for this run