Various minor updates and CVE fixes

1. Update from 3.12.11 to 3.12.13
2. Fixed black pre-commit to use 3.12 syntax
3. Bumped dependencies to resolve CVEs
4. Code Quality: Black formatting
5. Replaced i with _ in loop which is best practice

Author: seanorama

.pre-commit-config.yaml

@@ -3,7 +3,7 @@ repos:
     rev: 24.4.2
     hooks:
       - id: black
-        language_version: python3.10
+        language_version: python3.12
 
   - repo: https://github.com/Yelp/detect-secrets
     rev: v1.4.0

.python-version

@@ -1 +1 @@
-3.12.11
+3.12.13

Dockerfile

@@ -1,6 +1,6 @@
 # Build stage
 # When upgrading Python versions, update '.python-version' to match
-FROM python:3.12.11 AS builder
+FROM python:3.12.13 AS builder
 
 COPY --from=ghcr.io/astral-sh/uv:latest /uv /usr/local/bin/uv
 
@@ -24,7 +24,7 @@ RUN uv sync --locked --no-dev --no-editable
 ################################################################################
 # Runtime stage
 # When upgrading Python versions, update '.python-version' to match
-FROM python:3.12.11-slim
+FROM python:3.12.13-slim
 
 ENV DEBIAN_FRONTEND=noninteractive
 ENV LANG=C.UTF-8

jf_agent/main.py

@@ -607,7 +607,9 @@ def obtain_jellyfish_endpoint_info(config, creds, skip_jf_ingest_issue_metadata:
     return JellyfishEndpointInfo(jira_info, git_instance_info, jf_options)
 
 
-def _get_additional_jira_issue_metadata(base_url: str, api_token: str, cursor: int, skip_ssl_verification: bool = False) -> dict:
+def _get_additional_jira_issue_metadata(
+    base_url: str, api_token: str, cursor: int, skip_ssl_verification: bool = False
+) -> dict:
     headers = {'Jellyfish-API-Token': api_token}
     endpoint = f'{base_url}/endpoints/agent/jira-issue-metadata'
 
@@ -733,9 +735,9 @@ def generate_manifests(config, creds, jellyfish_endpoint_info):
 
 # far more straightforward than real bin packing because we have a set number of bins to start
 def _pack_bins(num_bins: int, packing_items: list[ProjectMetadata]) -> list:
-    bins = [[] for i in range(num_bins)]
+    bins = [[] for _ in range(num_bins)]
     bin_size = [
-        0 for i in range(num_bins)
+        0 for _ in range(num_bins)
     ]  # size is based on number of *repos* in a bin, not projects
 
     for item in packing_items:

tests/test_config_file.py

@@ -8,9 +8,12 @@
 
 from jf_agent.config_file_reader import (
     GitConfig,
+    ValidatedConfig,
     _get_git_config_from_yaml,
     _get_jf_ingest_git_auth_config,
+    obtain_config,
 )
+from jf_agent.exception import BadConfigException
 
 
 class TestGitConfigGeneration(TestCase):