ref: use a constants for the min length of searched text

Author: Jenselme

legadilo/constants.py

@@ -0,0 +1,17 @@
+# Legadilo
+# Copyright (C) 2023-2025 by Legadilo contributors.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+SEARCHED_TEXT_MIN_LENGTH = 3

legadilo/feeds/models/feed.py

@@ -32,6 +32,7 @@
 from legadilo.reading.models.tag import Tag
 from legadilo.users.models import User
 
+from ...constants import SEARCHED_TEXT_MIN_LENGTH
 from ...users.models import Notification
 from ...utils.time_utils import utcnow
 from .. import constants as feeds_constants
@@ -216,7 +217,7 @@ def get_by_categories(
             .order_by("category__title", "id")
         )
 
-        if len(searched_text) > 3:  # noqa: PLR2004 Magic value used in comparison
+        if len(searched_text) > SEARCHED_TEXT_MIN_LENGTH:
             qs = qs.filter(title__icontains=searched_text)
 
         for feed in qs:

legadilo/reading/models/tag.py

@@ -25,6 +25,7 @@
 from django.db.models.functions import Coalesce
 from slugify import slugify
 
+from legadilo.constants import SEARCHED_TEXT_MIN_LENGTH
 from legadilo.core import constants as core_constants
 from legadilo.core.forms import FormChoices
 from legadilo.reading import constants
@@ -177,7 +178,7 @@ def list_for_admin(self, user: User, searched_text: str = "") -> list[Tag]:
             .order_by("title")
         )
 
-        if len(searched_text) > 3:  # noqa: PLR2004 Magic value used in comparison
+        if len(searched_text) > SEARCHED_TEXT_MIN_LENGTH:
             qs = qs.filter(title__icontains=searched_text)
 
         return list(qs)

legadilo/reading/views/search_views.py

@@ -37,6 +37,7 @@
 from legadilo.users.user_types import AuthenticatedHttpRequest
 from legadilo.utils.security import full_sanitize
 
+from ...constants import SEARCHED_TEXT_MIN_LENGTH
 from ...users.models import User
 from ...utils.collections_utils import alist, aset
 from ...utils.validators import is_url_valid
@@ -45,7 +46,7 @@
 
 class SearchForm(forms.Form):
     # Main fields.
-    q = forms.CharField(required=True, min_length=4, label=_("Search query"))
+    q = forms.CharField(required=True, min_length=SEARCHED_TEXT_MIN_LENGTH, label=_("Search query"))
     search_type = forms.ChoiceField(
         required=False,
         choices=constants.ArticleSearchType.choices,
@@ -125,7 +126,8 @@ def clean_q(self):
         q = full_sanitize(q)
         if len(q) < self.fields["q"].min_length:  # type: ignore[attr-defined]
             raise ValidationError(
-                "You must at least enter 3 characters", code="q-too-short-after-cleaning"
+                f"You must at least enter {SEARCHED_TEXT_MIN_LENGTH} characters",
+                code="q-too-short-after-cleaning",
             )
 
         return q