fix: resolve chplcheck lint violations

  - Fix UnusedLoopIndex: replace `for i in 1..n` with `for 1..n`
  - Fix UnusedFormal: extract helper procs with @chplcheck.ignore
  - Fix LineLength: break long lines under 80 chars
  - Update CI threshold to 7 (acceptable API design violations)
  EOF

Author: OutBot CI

.github/workflows/ci.yml

@@ -151,9 +151,9 @@ jobs:
           echo ""
 
           # Known acceptable violations:
-          # - 8 CamelCaseRecords (generator types - intentional API)
+          # - 6 CamelCaseRecords (generator types - intentional API)
           # - 1 PascalCaseModules (quickchpl - package name)
-          ACCEPTABLE=9
+          ACCEPTABLE=7
 
           if [ "$VIOLATIONS" -gt "$ACCEPTABLE" ]; then
             echo "❌ Too many chplcheck violations (expected <=$ACCEPTABLE, got $VIOLATIONS)"

.gitlab-ci.yml

@@ -52,9 +52,9 @@ lint:chplcheck:
       echo ""
 
       # Known acceptable violations:
-      # - 8 CamelCaseRecords (generator types - intentional API)
+      # - 6 CamelCaseRecords (generator types - intentional API)
       # - 1 PascalCaseModules (quickchpl - package name)
-      ACCEPTABLE=9
+      ACCEPTABLE=7
 
       if [ "$VIOLATIONS" -gt "$ACCEPTABLE" ]; then
         echo "❌ Too many chplcheck violations (expected <=$ACCEPTABLE, got $VIOLATIONS)"

README.md

@@ -9,13 +9,6 @@
 Inspired by QuickCheck and my father ^w^
 
 
-Manual installation:
-```bash
-# clone
-export CHPL_MODULE_PATH=$CHPL_MODULE_PATH:$PWD/quickchpl/src
-```
-
-
 ```chapel
 use quickchpl;
 
@@ -278,6 +271,11 @@ property_tests:
 
 ## Configuration
 
+
+```bash
+export CHPL_MODULE_PATH=$CHPL_MODULE_PATH:$PWD/quickchpl/src
+```
+
 ```bash
 ./my_tests --numTests=1000 --maxShrinkSteps=500 --verbose=true
 ```

test/properties/SelfTests.chpl

@@ -5,6 +5,13 @@ module SelfTests {
   use quickchpl;
   use List;
 
+  // Helper procs for property tests (intentionally ignore formal)
+  @chplcheck.ignore("UnusedFormal")
+  proc alwaysTrue(x: int) { return true; }
+
+  @chplcheck.ignore("UnusedFormal")
+  proc alwaysFalse(x: int) { return false; }
+
   proc main() {
     writeln("quickchpl Self-Tests (PBT on PBT!)");
     writeln("=" * 50);
@@ -105,7 +112,8 @@ module SelfTests {
         "zip produces valid pairs",
         zippedGen,
         proc(pair: (int, int)) {
-          return pair(0) >= 0 && pair(0) <= 50 && pair(1) >= 100 && pair(1) <= 150;
+          return pair(0) >= 0 && pair(0) <= 50 &&
+                 pair(1) >= 100 && pair(1) <= 150;
         }
       );
       var result = check(prop);
@@ -199,12 +207,12 @@ module SelfTests {
     {
       // A property that always passes should report passed=true
       var passingGen = intGen(-100, 100);
-      var passingProp = property("always true", passingGen, proc(x: int) { return true; });
+      var passingProp = property("always true", passingGen, alwaysTrue);
       var passingResult = check(passingProp, 50);
 
       // A property that always fails should report passed=false
       var failingGen = intGen(1, 100);
-      var failingProp = property("always false", failingGen, proc(x: int) { return false; });
+      var failingProp = property("always false", failingGen, alwaysFalse);
       var failingResult = check(failingProp, 50);
 
       if passingResult.passed && !failingResult.passed {

test/unit/GeneratorTests.chpl

@@ -24,7 +24,7 @@ module GeneratorTests {
       var sawDifferent = false;
       var first = gen.next();
 
-      for i in 1..numTests {
+      for 1..numTests {
         const value = gen.next();
         if value < -100 || value > 100 then inRange = false;
         if value != first then sawDifferent = true;
@@ -54,7 +54,7 @@ module GeneratorTests {
       var gen = realGen(0.0, 1.0, Distribution.Uniform, seed);
       var inRange = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const value = gen.next();
         if value < 0.0 || value >= 1.0 then inRange = false;
       }
@@ -76,15 +76,16 @@ module GeneratorTests {
       var trueCount = 0;
       var falseCount = 0;
 
-      for i in 1..1000 {
+      for 1..1000 {
         if gen.next() then trueCount += 1;
         else falseCount += 1;
       }
 
       // With p=0.5, expect roughly 50% each (allow 30-70%)
       const trueRatio = trueCount: real / 1000.0;
       if trueRatio >= 0.3 && trueRatio <= 0.7 {
-        writeln("  ✓ Reasonable true/false distribution (", trueCount, "/", falseCount, ")");
+        writeln("  ✓ Reasonable true/false distribution (",
+                trueCount, "/", falseCount, ")");
         passed += 1;
       } else {
         writeln("  ✗ Biased distribution (", trueCount, "/", falseCount, ")");
@@ -100,7 +101,7 @@ module GeneratorTests {
       var validLength = true;
       var validChars = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const value = gen.next();
         if value.size < 5 || value.size > 10 then validLength = false;
         for c in value {
@@ -132,7 +133,7 @@ module GeneratorTests {
       var gen = tupleGen(intGen(0, 10, seed), intGen(100, 200, seed + 1));
       var valid = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const (a, b) = gen.next();
         if a < 0 || a > 10 then valid = false;
         if b < 100 || b > 200 then valid = false;
@@ -154,7 +155,7 @@ module GeneratorTests {
       var gen = listGen(intGen(0, 10, seed), 3, 7, seed);
       var validSizes = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const lst = gen.next();
         if lst.size < 3 || lst.size > 7 then validSizes = false;
       }
@@ -175,7 +176,7 @@ module GeneratorTests {
       var gen = constantGen(42);
       var allSame = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         if gen.next() != 42 then allSame = false;
       }
 
@@ -196,7 +197,7 @@ module GeneratorTests {
       var doubledGen = map(baseGen, proc(x: int) { return x * 2; });
       var allEven = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const value = doubledGen.next();
         if value % 2 != 0 then allEven = false;
       }
@@ -218,7 +219,7 @@ module GeneratorTests {
       var positiveGen = filter(baseGen, proc(x: int) { return x > 0; });
       var allPositive = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const value = positiveGen.next();
         if value <= 0 then allPositive = false;
       }
@@ -241,7 +242,7 @@ module GeneratorTests {
       var zippedGen = zipGen(gen1, gen2);
       var valid = true;
 
-      for i in 1..numTests {
+      for 1..numTests {
         const (n, s) = zippedGen.next();
         if n < 0 || n > 10 then valid = false;
         if s.size < 1 || s.size > 3 then valid = false;

test/unit/PropertyTests.chpl

@@ -7,6 +7,13 @@ module PropertyTests {
 
   config const numTests = 50;
 
+  // Helper procs for property tests (intentionally ignore formal)
+  @chplcheck.ignore("UnusedFormal")
+  proc alwaysTrue(x: int) { return true; }
+
+  @chplcheck.ignore("UnusedFormal")
+  proc alwaysFalse(x: int) { return false; }
+
   proc main() {
     writeln("quickchpl Property System Unit Tests");
     writeln("=" * 50);
@@ -19,11 +26,7 @@ module PropertyTests {
     writeln("Testing Basic Property (always passes):");
     {
       var gen = intGen(-100, 100);
-      var prop = property(
-        "integers exist",
-        gen,
-        proc(x: int) { return true; }
-      );
+      var prop = property("integers exist", gen, alwaysTrue);
 
       var result = check(prop, numTests);
 
@@ -137,7 +140,8 @@ module PropertyTests {
         failed += 1;
       }
 
-      var failResult = quickCheck(intGen(1, 100), proc(x: int) { return x < 0; });
+      var failResult = quickCheck(intGen(1, 100),
+        proc(x: int) { return x < 0; });
       if !failResult {
         writeln("  ✓ quickCheck correctly returns false for failing property");
         passed += 1;
@@ -155,7 +159,9 @@ module PropertyTests {
       var prop = property(
         "addition is commutative",
         gen,
-        proc(pair: (int, int)) { return pair(0) + pair(1) == pair(1) + pair(0); }
+        proc(pair: (int, int)) {
+          return pair(0) + pair(1) == pair(1) + pair(0);
+        }
       );
 
       var result = check(prop, numTests);
@@ -196,7 +202,8 @@ module PropertyTests {
     writeln("Testing TestResult Structure:");
     {
       var gen = intGen(0, 10);
-      var prop = property("test property", gen, proc(x: int) { return x >= 0; });
+      var prop = property("test property", gen,
+        proc(x: int) { return x >= 0; });
       var result = check(prop, 25);
 
       if result.propertyName == "test property" {
@@ -222,10 +229,10 @@ module PropertyTests {
     {
       var results: list(TestResult);
 
-      var r1 = new TestResult(passed=true, numTests=10, numPassed=10, numFailed=0,
-                               propertyName="p1");
-      var r2 = new TestResult(passed=true, numTests=10, numPassed=10, numFailed=0,
-                               propertyName="p2");
+      var r1 = new TestResult(passed=true, numTests=10,
+        numPassed=10, numFailed=0, propertyName="p1");
+      var r2 = new TestResult(passed=true, numTests=10,
+        numPassed=10, numFailed=0, propertyName="p2");
       results.pushBack(r1);
       results.pushBack(r2);
 
@@ -237,8 +244,8 @@ module PropertyTests {
         failed += 1;
       }
 
-      var r3 = new TestResult(passed=false, numTests=10, numPassed=5, numFailed=5,
-                               propertyName="p3");
+      var r3 = new TestResult(passed=false, numTests=10,
+        numPassed=5, numFailed=5, propertyName="p3");
       results.pushBack(r3);
 
       if !allPassed(results) {

test/unit/ShrinkerTests.chpl

@@ -228,7 +228,8 @@ module ShrinkerTests {
     {
       // Property that fails for numbers >= 10
       // Should shrink to 10
-      const (shrunk, steps) = shrinkIntFailure(100, proc(x: int) { return x < 10; });
+      const (shrunk, steps) = shrinkIntFailure(100,
+        proc(x: int) { return x < 10; });
 
       if shrunk == 10 {
         writeln("  ✓ Shrinks 100 to 10 (minimal failing case)");