Skip to content

Commit b773b6f

Browse files
bourgesljbrbot
authored and
jbrbot
committed
JBR-8278: fixed performOnMainThreadWaiting run block condition to fix FullscreenWindowProps and NoResizeEventOnDMChangeTest tests
1 parent 446f2e0 commit b773b6f

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m

+3-6
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
return; \
3838
}
3939

40-
#define RUN_BLOCK_IF_MAIN(block) \
41-
RUN_BLOCK_IF([NSThread isMainThread], block)
42-
4340
/* Returns the MainThread latency threshold in milliseconds
4441
* used to detect slow operations that may cause high latencies or delays.
4542
* If negative, the MainThread monitor is disabled */
@@ -340,7 +337,7 @@ + (NSString*)getCallerStack:(NSString*)prefixSymbol {
340337
+ (void)performOnMainThreadNowOrLater:(BOOL)useJavaModes
341338
block:(void (^)())block
342339
{
343-
RUN_BLOCK_IF_MAIN(block);
340+
RUN_BLOCK_IF([NSThread isMainThread], block);
344341

345342
[ThreadUtilities performOnMainThread:@selector(invokeBlockCopy:) on:self withObject:Block_copy(block)
346343
waitUntilDone:NO useJavaModes:useJavaModes];
@@ -362,7 +359,7 @@ + (void)performOnMainThreadWaiting:(BOOL)wait
362359
useJavaModes:(BOOL)useJavaModes
363360
block:(void (^)())block
364361
{
365-
RUN_BLOCK_IF_MAIN(block);
362+
RUN_BLOCK_IF([NSThread isMainThread] && wait, block);
366363

367364
[ThreadUtilities performOnMainThread:@selector(invokeBlockCopy:) on:self withObject:Block_copy(block)
368365
waitUntilDone:wait useJavaModes:useJavaModes];
@@ -443,7 +440,7 @@ + (void)performOnMainThreadWithTracing:(SEL)aSelector
443440
waitUntilDone:(BOOL)wait
444441
useJavaModes:(BOOL)useJavaModes
445442
{
446-
const BOOL invokeDirect = NSThread.isMainThread && wait;
443+
const BOOL invokeDirect = [NSThread isMainThread] && wait;
447444
const BOOL doWait = !invokeDirect && wait;
448445
const BOOL blockingEDT = doWait && isEventDispatchThread();
449446

0 commit comments

Comments
 (0)