Skip to content

Commit c7ce419

Browse files
nkoesternkoester
authored
Merge pull request #1697 from JetBrains/bugfix/navigationSupportGetInstance
Remove deprecated `getInstance()` calls
2 parents ba23d1c + 7fa4411 commit c7ce419

File tree

5 files changed

+72
-3
lines changed

5 files changed

+72
-3
lines changed

‎CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project are documented in this file.
44

55
The format is *loosely* based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) .The project does *not* follow Semantic Versioning and the changes are documented in reverse chronological order, grouped by calendar month.
66

7+
## December 2025
8+
9+
### Fixed
10+
11+
- Migrate all usages of deprecated getInstance() from [NavigationSupport](http://127.0.0.1:63320/node?ref=1ed103c3-3aa6-49b7-9c21-6765ee11f224%2Fjava%3Ajetbrains.mps.openapi.navigation%28MPS.Editor%2F%29%2F~NavigationSupport) to its replacement getInstance(Project mpsProject)
12+
713
## November 2025
814

915
### Added

‎code/diagram/solutions/de.itemis.mps.editor.diagram.runtime/models/de/itemis/mps/editor/diagram/runtime/jgraph.mps‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148472,7 +148472,10 @@
148472148472
<node concept="2OqwBi" id="6OfpnAg4LOp" role="33vP2m">
148473148473
<node concept="2YIFZM" id="6OfpnAg4LOq" role="2Oq$k0">
148474148474
<ref role="1Pybhc" to="kz9k:~NavigationSupport" resolve="NavigationSupport" />
148475-
<ref role="37wK5l" to="kz9k:~NavigationSupport.getInstance()" resolve="getInstance" />
148475+
<ref role="37wK5l" to="kz9k:~NavigationSupport.getInstance(jetbrains.mps.project.Project)" resolve="getInstance" />
148476+
<node concept="37vLTw" id="6xbWs8PxI0k" role="37wK5m">
148477+
<ref role="3cqZAo" node="6OfpnAg4LO0" resolve="project" />
148478+
</node>
148476148479
</node>
148477148480
<node concept="liA8E" id="6OfpnAg4LOr" role="2OqNvi">
148478148481
<ref role="37wK5l" to="kz9k:~NavigationSupport.openNode(jetbrains.mps.project.Project,org.jetbrains.mps.openapi.model.SNode,boolean,boolean)" resolve="openNode" />

‎code/pagination/solutions/de.itemis.mps.editor.pagination.runtime/models/de.itemis.mps.editor.pagination.runtime.plugin.utils.mps‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -734,8 +734,11 @@
734734
</node>
735735
<node concept="2OqwBi" id="47Pq93I76_w" role="2Oq$k0">
736736
<node concept="2YIFZM" id="47Pq93I76_x" role="2Oq$k0">
737-
<ref role="37wK5l" to="kz9k:~NavigationSupport.getInstance()" resolve="getInstance" />
737+
<ref role="37wK5l" to="kz9k:~NavigationSupport.getInstance(jetbrains.mps.project.Project)" resolve="getInstance" />
738738
<ref role="1Pybhc" to="kz9k:~NavigationSupport" resolve="NavigationSupport" />
739+
<node concept="37vLTw" id="6xbWs8PwXao" role="37wK5m">
740+
<ref role="3cqZAo" node="47Pq93I22AF" resolve="project" />
741+
</node>
739742
</node>
740743
<node concept="liA8E" id="47Pq93I76_y" role="2OqNvi">
741744
<ref role="37wK5l" to="kz9k:~NavigationSupport.openNode(jetbrains.mps.project.Project,org.jetbrains.mps.openapi.model.SNode,boolean,boolean)" resolve="openNode" />

‎code/shadowmodels/de.q60.mps.explorer/models/de.q60.mps.explorer.mps‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3098,7 +3098,10 @@
30983098
<node concept="2OqwBi" id="5wnrAmUlvXX" role="3clFbG">
30993099
<node concept="2YIFZM" id="5wnrAmUlvXY" role="2Oq$k0">
31003100
<ref role="1Pybhc" to="kz9k:~NavigationSupport" resolve="NavigationSupport" />
3101-
<ref role="37wK5l" to="kz9k:~NavigationSupport.getInstance()" resolve="getInstance" />
3101+
<ref role="37wK5l" to="kz9k:~NavigationSupport.getInstance(jetbrains.mps.project.Project)" resolve="getInstance" />
3102+
<node concept="37vLTw" id="6xbWs8Pxtj0" role="37wK5m">
3103+
<ref role="3cqZAo" node="5wnrAmTJlJb" resolve="myProject" />
3104+
</node>
31023105
</node>
31033106
<node concept="liA8E" id="5wnrAmUlvXZ" role="2OqNvi">
31043107
<ref role="37wK5l" to="kz9k:~NavigationSupport.openNode(jetbrains.mps.project.Project,org.jetbrains.mps.openapi.model.SNode,boolean,boolean)" resolve="openNode" />

‎code/solutions/de.itemis.mps.extensions.changelog/models/de.itemis.mps.extensions.changelog.mps‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<import index="mhfm" ref="3f233e7f-b8a6-46d2-a57f-795d56775243/java:org.jetbrains.annotations(Annotations/)" />
1515
<import index="teg0" ref="r:96165ed2-ef22-48c7-bfe5-8fce083cbabb(com.mbeddr.mpsutil.grammarcells.structure)" />
1616
<import index="tegv" ref="r:b91d2412-f094-4e55-8db6-3c782d7edc40(com.mbeddr.mpsutil.intentions.structure)" />
17+
<import index="kz9k" ref="1ed103c3-3aa6-49b7-9c21-6765ee11f224/java:jetbrains.mps.openapi.navigation(MPS.Editor/)" />
1718
</imports>
1819
<registry>
1920
<language id="638c9345-2613-49dc-b2ae-8ceadef24141" name="de.itemis.mps.changelog">
@@ -234,6 +235,59 @@
234235
</node>
235236
</node>
236237
</node>
238+
<node concept="15bmVD" id="6xbWs8QlwdI" role="15bmVC">
239+
<node concept="15ShDW" id="6xbWs8QlwdF" role="15bq2Y">
240+
<property role="15ShDY" value="Po4Z58IgBx/December" />
241+
<property role="15ShDw" value="2025" />
242+
</node>
243+
<node concept="15bAme" id="6xbWs8QlwdG" role="15bAlL">
244+
<node concept="2DRihI" id="6xbWs8QlwdH" role="15bAlk">
245+
<node concept="3oM_SD" id="6xbWs8QlwdK" role="1PaTwD">
246+
<property role="3oM_SC" value="Migrate" />
247+
</node>
248+
<node concept="3oM_SD" id="6xbWs8QlwjY" role="1PaTwD">
249+
<property role="3oM_SC" value="all" />
250+
</node>
251+
<node concept="3oM_SD" id="6xbWs8QlwdL" role="1PaTwD">
252+
<property role="3oM_SC" value="usages" />
253+
</node>
254+
<node concept="3oM_SD" id="6xbWs8QlwdM" role="1PaTwD">
255+
<property role="3oM_SC" value="of" />
256+
</node>
257+
<node concept="3oM_SD" id="6xbWs8QlwdN" role="1PaTwD">
258+
<property role="3oM_SC" value="deprecated" />
259+
</node>
260+
<node concept="3oM_SD" id="6xbWs8QlwjW" role="1PaTwD">
261+
<property role="3oM_SC" value="getInstance()" />
262+
</node>
263+
<node concept="3oM_SD" id="6xbWs8QlwjX" role="1PaTwD">
264+
<property role="3oM_SC" value="from" />
265+
</node>
266+
<node concept="15BRQy" id="6xbWs8QlwjG" role="1PaTwD">
267+
<node concept="2tJFMh" id="6xbWs8QlwjI" role="15BRQ_">
268+
<node concept="ZC_QK" id="6xbWs8QlwjO" role="2tJFKM">
269+
<ref role="2aWVGs" to="kz9k:~NavigationSupport" resolve="NavigationSupport" />
270+
</node>
271+
</node>
272+
</node>
273+
<node concept="3oM_SD" id="6xbWs8Qlwk0" role="1PaTwD">
274+
<property role="3oM_SC" value="to" />
275+
</node>
276+
<node concept="3oM_SD" id="6xbWs8Qlwk1" role="1PaTwD">
277+
<property role="3oM_SC" value="its" />
278+
</node>
279+
<node concept="3oM_SD" id="6xbWs8Qlwk2" role="1PaTwD">
280+
<property role="3oM_SC" value="replacement" />
281+
</node>
282+
<node concept="3oM_SD" id="6xbWs8Qlwk3" role="1PaTwD">
283+
<property role="3oM_SC" value="getInstance(Project" />
284+
</node>
285+
<node concept="3oM_SD" id="6Ma6J$ktwcx" role="1PaTwD">
286+
<property role="3oM_SC" value="mpsProject)" />
287+
</node>
288+
</node>
289+
</node>
290+
</node>
237291
<node concept="15bmVD" id="6Qwtr1aMjHs" role="15bmVC">
238292
<node concept="15ShDW" id="6Qwtr1aMjHp" role="15bq2Y">
239293
<property role="15ShDY" value="Po4Z58IgBl/November" />

0 commit comments

Comments
 (0)