Refactor extensions of j.m.l.editor generator not to use transitition code #1708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n code factory method used to get 2 parameters, and was replaced with no-arg alternative long time ago (cca 2016?), with transition template introducing new no-arg method with proper ML (cellFactory.factoryMethod) that invoked old method with context values. With migration and transitional template gone, either refactor method to match modern signature or inline transitional code (for complex scenarios like diagram and tables, with a lot of assumptions downstream about 'node' variable being accessible everywhere, see Parameter_Node and QueryParameter_Node in respective languages)
artem-tikhomirov
requested review from
sergej-koscejev and
wsafonov
as code owners
sergej-koscejev
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factory method used to get 2 parameters, and was replaced with no-arg alternative long time ago (cca 2016?), with transition template introducing new no-arg method with proper ML (cellFactory.factoryMethod) that invoked old method with context values.
With migration and transitional template gone, either refactor method to match modern signature or inline transitional code (for complex scenarios like diagram and tables, with a lot of assumptions
downstream about 'node' variable being accessible everywhere, see
Parameter_Node and QueryParameter_Node in respective languages)