VIM-4120 extract base classes for output panel and model

Author: 1grzyb1

src/main/java/com/maddyhome/idea/vim/ex/ExOutputModel.kt

@@ -7,45 +7,41 @@
  */
 package com.maddyhome.idea.vim.ex
 
-import com.intellij.openapi.application.ApplicationManager
 import com.intellij.openapi.editor.Editor
-import com.maddyhome.idea.vim.api.VimOutputPanelBase
-import com.maddyhome.idea.vim.api.injector
 import com.maddyhome.idea.vim.helper.vimExOutput
 import com.maddyhome.idea.vim.ui.ExOutputPanel
+import com.maddyhome.idea.vim.ui.IjOutputModelBase
+import java.awt.event.KeyEvent
 import java.lang.ref.WeakReference
 import javax.swing.KeyStroke
 
 // TODO: We need a nicer way to handle output, especially wrt testing, appending + clearing
-class ExOutputModel(private val myEditor: WeakReference<Editor>) : VimOutputPanelBase() {
-  private var isActiveInTestMode = false
+class ExOutputModel(editor: WeakReference<Editor>) : IjOutputModelBase<ExOutputPanel>(editor) {
 
-  val editor get() = myEditor.get()
+  override fun onBeforeShow() {
+    editor?.let { it.vimExOutput = this }
+  }
 
-  override val isActive: Boolean
-    get() = if (!ApplicationManager.getApplication().isUnitTestMode) {
-      editor?.let { ExOutputPanel.getNullablePanel(it) }?.myActive ?: false
-    } else {
-      isActiveInTestMode
+  override fun handleKey(key: KeyStroke) {
+    if (atEnd) {
+      closeWithKey(key)
+      return
     }
 
-  override fun addText(text: String, isNewLine: Boolean) {
-    if (this.text.isNotEmpty() && isNewLine) this.text += "\n$text" else this.text += text
-  }
-
-  override fun show() {
-    if (editor == null) return
-    val currentPanel = injector.outputPanel.getCurrentOutputPanel()
-    if (currentPanel != null && currentPanel != this) currentPanel.close()
-
-    editor!!.vimExOutput = this
-    val exOutputPanel = ExOutputPanel.getInstance(editor!!)
-    if (!exOutputPanel.myActive) {
-      if (ApplicationManager.getApplication().isUnitTestMode) {
-        isActiveInTestMode = true
-      } else {
-        exOutputPanel.activate()
+    when (key.keyChar) {
+      ' ' -> scrollPage()
+      'd' -> scrollHalfPage()
+      'q', '\u001b' -> close()
+      '\n' -> scrollLine()
+      KeyEvent.CHAR_UNDEFINED -> {
+        when (key.keyCode) {
+          KeyEvent.VK_ENTER -> scrollLine()
+          KeyEvent.VK_ESCAPE -> close()
+          else -> onBadKey()
+        }
       }
+
+      else -> onBadKey()
     }
   }
 
@@ -67,32 +63,6 @@ class ExOutputModel(private val myEditor: WeakReference<Editor>) : VimOutputPane
     panel.scrollLine()
   }
 
-  override fun setContent(text: String) {
-    this.text = text
-  }
-
-  override fun clearText() {
-    text = ""
-  }
-
-  override var text: String = ""
-    get() = if (!ApplicationManager.getApplication().isUnitTestMode) {
-      editor?.let { ExOutputPanel.getInstance(it).text } ?: ""
-    } else {
-      // ExOutputPanel always returns a non-null string
-      field
-    }
-    set(value) {
-      // ExOutputPanel will strip a trailing newline. We'll do it now so that tests have the same behaviour. We also
-      // never pass null to ExOutputPanel, but we do store it for tests, so we know if we're active or not
-      val newValue = value.removeSuffix("\n")
-      if (!ApplicationManager.getApplication().isUnitTestMode) {
-        editor?.let { ExOutputPanel.getInstance(it).text = newValue }
-      } else {
-        field = newValue
-        isActiveInTestMode = newValue.isNotEmpty()
-      }
-    }
   override var label: String
     get() {
       val notNullEditor = editor ?: return ""
@@ -113,31 +83,25 @@ class ExOutputModel(private val myEditor: WeakReference<Editor>) : VimOutputPane
     text = ""
   }
 
-  override val atEnd: Boolean
+  private val atEnd: Boolean
     get() {
       val notNullEditor = editor ?: return false
       val panel = ExOutputPanel.getNullablePanel(notNullEditor) ?: return false
       return panel.isAtEnd
     }
 
-  override fun onBadKey() {
+  private fun onBadKey() {
     val notNullEditor = editor ?: return
     val panel = ExOutputPanel.getNullablePanel(notNullEditor) ?: return
     panel.onBadKey()
   }
 
-  override fun close(key: KeyStroke?) {
-    val notNullEditor = editor ?: return
-    val panel = ExOutputPanel.getNullablePanel(notNullEditor) ?: return
-    panel.close(key)
+  override fun getNullablePanel(): ExOutputPanel? {
+    return editor?.let { ExOutputPanel.getNullablePanel(it) }
   }
 
-  override fun close() {
-    if (!ApplicationManager.getApplication().isUnitTestMode) {
-      editor?.let { ExOutputPanel.getInstance(it).close() }
-    } else {
-      isActiveInTestMode = false
-    }
+  override fun getOrCreatePanel(): ExOutputPanel {
+    return ExOutputPanel.getInstance(editor!!)
   }
 
   companion object {