[cucumber-java] IDEA-211600 add more tests for resolve of Cucumber parameter types from an external library

GitOrigin-RevId: 29f4cb4fac495e935ba161541f37dc14f0ece2e0

Author: bartekpacia

cucumber-java/test/org/jetbrains/plugins/cucumber/java/resolve/CucumberJavaResolveToExternalLibraryTest.java

@@ -1,7 +1,6 @@
 // Copyright 2000-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
 package org.jetbrains.plugins.cucumber.java.resolve;
 
-import com.intellij.openapi.application.PathManager;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.roots.ContentEntry;
 import com.intellij.openapi.roots.ModifiableRootModel;
@@ -15,10 +14,16 @@
 
 public class CucumberJavaResolveToExternalLibraryTest extends BaseCucumberJavaResolveTest {
 
-  public void testResolveWithParameterTypeDouble() {
-    init("resolveToExternalLibrary");
+  public void testResolveManySteps() {
+    init(getTestName(true));
 
-    checkReference("step w<caret>ith", "stepWithDoubleParameterType");
+    checkReference("<caret>I have a normal some parameter", "normal");
+    checkReference("<caret>I have this parameter", "alternative");
+    checkReference("<caret>I have that parameter", "alternative");
+    checkReference("<caret>I have or not parameter", "optional");
+    checkReference("<caret>I have or not", "optional");
+    // FIXME: doesn't work for custom '@ParameterType's defined in external libraries. See IDEA-211600.
+    // checkReference("<caret>I have a custom blah parameter", "custom");
   }
 
   @Override
@@ -28,17 +33,22 @@ protected LightProjectDescriptor getProjectDescriptor() {
       public void configureModule(@NotNull Module module, @NotNull ModifiableRootModel model, @NotNull ContentEntry contentEntry) {
         IntelliJProjectConfiguration.LibraryRoots
           libraryRoots = IntelliJProjectConfiguration.getModuleLibrary("intellij.cucumber.java", "cucumber-core-5.5");
-        PsiTestUtil.addProjectLibrary(model, "cucumber-core", libraryRoots.getClassesPaths());
+        PsiTestUtil.addProjectLibrary(model, "my-cucumber-core", libraryRoots.getClassesPaths());
 
         libraryRoots = IntelliJProjectConfiguration.getModuleLibrary("intellij.cucumber.java", "cucumber-java-5.5");
-        PsiTestUtil.addProjectLibrary(model, "cucumber-java", libraryRoots.getClassesPaths());
+        PsiTestUtil.addProjectLibrary(model, "my-cucumber-java", libraryRoots.getClassesPaths());
 
         attachCucumberExpressionsLibrary(model);
 
-        PsiTestUtil.addLibrary(model, "cucumber-java8",
-                               PathManager.getHomePath() + "/contrib/cucumber-java/testData/resolve/resolveToExternalLibrary",
-                               "step-def-jar-1.0.jar");
+        PsiTestUtil.addLibrary(model, "my-cucumber-java8",
+                               getTestDataPath() + "/resolveManySteps",
+                               "steps-1.0.0.jar");
       }
     };
   }
+
+  @Override
+  protected String getTestDataPath() {
+    return super.getTestDataPath() + "/resolveToExternalLibrary";
+  }
 }

cucumber-java/testData/resolve/resolveToExternalLibrary/project/.gitignore

@@ -0,0 +1 @@
+target/

cucumber-java/testData/resolve/resolveToExternalLibrary/project/README.md

@@ -0,0 +1,13 @@
+This is a sample project to test resolving definitions of steps defined in a external library.
+
+Build a JAR:
+
+```shell
+mvn clean package
+```
+
+Move it to the right place:
+
+```shell
+cp target/steps-1.0.0.jar ../resolveManySteps/steps-1.0.0.jar
+```

cucumber-java/testData/resolve/resolveToExternalLibrary/project/pom.xml

@@ -0,0 +1,24 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+                             https://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>org.example</groupId>
+    <artifactId>steps</artifactId>
+    <version>1.0.0</version>
+    <packaging>jar</packaging>
+
+    <properties>
+        <maven.compiler.source>17</maven.compiler.source>
+        <maven.compiler.target>17</maven.compiler.target>
+    </properties>
+
+    <dependencies>
+        <dependency>
+            <groupId>io.cucumber</groupId>
+            <artifactId>cucumber-java</artifactId>
+            <version>7.29.0</version>
+        </dependency>
+    </dependencies>
+</project>

cucumber-java/testData/resolve/resolveToExternalLibrary/project/src/main/java/org/example/ExternalSteps.java

@@ -0,0 +1,31 @@
+package org.example;
+
+import io.cucumber.java.ParameterType;
+import io.cucumber.java.en.Given;
+
+public class ExternalSteps {
+  public boolean someLibraryMethod() {
+    return true;
+  }
+
+  @Given("I have a normal {word} parameter")
+  public void normal(String size) {
+  }
+
+  @Given("I have this/that parameter")
+  public void alternative() {
+  }
+
+  @Given("I have or not( parameter)")
+  public void optional() {
+  }
+
+  @Given("I have a custom {customParameter} parameter")
+  public void custom(String size) {
+  }
+
+  @ParameterType(".*")
+  public String customParameter(String arg) {
+    return arg;
+  }
+}

cucumber-java/testData/resolve/resolveToExternalLibrary/resolveManySteps/steps-1.0.0.jar

@@ -0,0 +1,13 @@
+Feature: Some feature
+
+  Scenario: Some scenario
+    # Normal
+    Given I have a normal some parameter
+    # Alternative
+    Given I have this parameter
+    Given I have that parameter
+    # Optional
+    Given I have or not parameter
+    Given I have or not
+    # Custom
+    Given I have a custom blah parameter