refactor: add meter interval to metric exporter individually, update tests

Author: Fant1k34

agents/agents-features/agents-features-opentelemetry/src/jvmMain/kotlin/ai/koog/agents/features/opentelemetry/feature/OpenTelemetryConfig.kt

@@ -67,7 +67,7 @@ public class OpenTelemetryConfig : FeatureConfig() {
 
     private val customResourceAttributes = mutableMapOf<AttributeKey<*>, Any>()
 
-    private val customMetricExporters = mutableListOf<MetricExporter>()
+    private val customMetricExporters = mutableListOf<Pair<MetricExporter, Duration>>()
 
     private var _sdk: OpenTelemetrySdk? = null
 
@@ -140,17 +140,14 @@ public class OpenTelemetryConfig : FeatureConfig() {
     public val meter: Meter
         get() = sdk.getMeter(_instrumentationScopeName)
 
-    private var meterInterval: Duration
-
     /**
      * Adds a MetricExporter to the OpenTelemetry configuration.
      * This exporter will be useds to export metrics collected during the application's execution.
      *
      * @param exporter The MetricExporter instance to be added to the list of custom metric exporters.
      */
     public fun addMeterExporter(exporter: MetricExporter, meterInterval: Duration = DEFAULT_METER_INTERVAL) {
-        customMetricExporters.add(exporter)
-        this.meterInterval = meterInterval
+        customMetricExporters.add(exporter to meterInterval)
     }
 
     /**
@@ -288,7 +285,7 @@ public class OpenTelemetryConfig : FeatureConfig() {
 
         val metricExporters = createMetricExporters()
 
-        metricExporters.forEach { exporter ->
+        metricExporters.forEach { (exporter, meterInterval) ->
             val reader = PeriodicMetricReader
                 .builder(exporter)
                 .setInterval(meterInterval)
@@ -345,15 +342,15 @@ public class OpenTelemetryConfig : FeatureConfig() {
         }
     }
 
-    private fun createMetricExporters(): List<MetricExporter> = buildList {
+    private fun createMetricExporters(): List<Pair<MetricExporter, Duration>> = buildList {
         if (customMetricExporters.isEmpty()) {
             logger.debug { "No custom metric exporters configured. Use log metric exporter by default." }
-            add(LoggingMetricExporter.create())
+            add(LoggingMetricExporter.create() to DEFAULT_METER_INTERVAL)
         }
 
-        customMetricExporters.forEach { exporter ->
+        customMetricExporters.forEach { (exporter, interval) ->
             logger.debug { "Adding metric exporter: ${exporter::class.simpleName}" }
-            add(exporter)
+            add(exporter to interval)
         }
     }
 

agents/agents-features/agents-features-opentelemetry/src/jvmTest/kotlin/ai/koog/agents/features/opentelemetry/attribute/GenAIAttributesTest.kt

@@ -89,13 +89,6 @@ class GenAIAttributesTest {
         assertEquals("call-123", attribute.value)
     }
 
-    @Test
-    fun `test status attribute`() {
-        val attribute = KoogAttributes.Koog.Tool.Call.Status(KoogAttributes.Koog.Tool.Call.StatusType.SUCCESS)
-        assertEquals("gen_ai.tool.call.status", attribute.key)
-        assertEquals("success", attribute.value)
-    }
-
     @Test
     fun `test tool name attribute`() {
         val attribute = GenAIAttributes.Tool.Name("search")

agents/agents-features/agents-features-opentelemetry/src/jvmTest/kotlin/ai/koog/agents/features/opentelemetry/attribute/KoogAttributesTest.kt

@@ -0,0 +1,13 @@
+package ai.koog.agents.features.opentelemetry.attribute
+
+import kotlin.test.Test
+import kotlin.test.assertEquals
+
+class KoogAttributesTest {
+    @Test
+    fun `test status attribute`() {
+        val attribute = KoogAttributes.Koog.Tool.Call.Status(KoogAttributes.Koog.Tool.Call.StatusType.SUCCESS)
+        assertEquals("koog.tool.call.status", attribute.key)
+        assertEquals("success", attribute.value)
+    }
+}