Skip to content

Commit 7feb6d4

Browse files
authored
[agents] Disable debugger tests because they're flaky (#1251)
See #1124, #1223, #1252 for more details
1 parent eb7dabb commit 7feb6d4

File tree

6 files changed

+10
-7
lines changed

6 files changed

+10
-7
lines changed

agents/agents-core/src/jvmTest/kotlin/ai/koog/agents/core/feature/AIAgentPipelineJvmTest.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import kotlin.time.Duration.Companion.seconds
3939
// System Properties set inside this test class affects the general agent logic.
4040
// It causes the other tests, running in parallel, to be affected by this property.
4141
// Isolate the environment by @Isolated annotation for these tests and make sure they are running without the parallelism.
42+
@Disabled("Flaky, see #1223")
4243
@Isolated
4344
@Execution(ExecutionMode.SAME_THREAD)
4445
class AIAgentPipelineJvmTest {
@@ -99,7 +100,6 @@ class AIAgentPipelineJvmTest {
99100
}
100101

101102
@Test
102-
@Disabled("Flaky, see #1223")
103103
@OptIn(ExperimentalAgentsApi::class)
104104
fun `test known system feature in config set by vm option`() = runTest(timeout = testTimeout) {
105105
val expectedPort = NetUtil.findAvailablePort()
@@ -124,7 +124,6 @@ class AIAgentPipelineJvmTest {
124124
}
125125

126126
@Test
127-
@Disabled("Flaky, see #1223")
128127
@OptIn(ExperimentalAgentsApi::class)
129128
fun `test known system feature is skipped if already installed in agent`() = runTest(timeout = testTimeout) {
130129
val expectedSystemPort = NetUtil.findAvailablePort()
@@ -207,7 +206,6 @@ class AIAgentPipelineJvmTest {
207206

208207
@Test
209208
@OptIn(ExperimentalAgentsApi::class)
210-
@Disabled("Flaky, see #1223")
211209
fun `test duplicate system features provided in config`() = runTest(timeout = testTimeout) {
212210
// Set System properties for test
213211
System.setProperty(

agents/agents-core/src/jvmTest/kotlin/ai/koog/agents/core/system/feature/DebuggerConfigTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import kotlin.time.toDuration
3636

3737
// System Properties set inside this test class affects other tests
3838
// Isolate the environment by @Isolated annotation for these tests and make sure they are running without the parallelism.
39+
@Disabled("Flaky, see #1124")
3940
@Isolated
4041
@Execution(ExecutionMode.SAME_THREAD)
4142
class DebuggerConfigTest {
@@ -72,7 +73,6 @@ class DebuggerConfigTest {
7273
}
7374

7475
@Test
75-
@Disabled("Flaky, see #1124")
7676
fun `test read port from vm option`() = runBlocking {
7777
// Set VM option
7878
val port = 56712
@@ -96,7 +96,6 @@ class DebuggerConfigTest {
9696
}
9797

9898
@Test
99-
@Disabled("Flaky, see #1124")
10099
fun `test read default port when not set by property or env variable or vm option`() = runBlocking {
101100
val portVmOptionName = @OptIn(ExperimentalAgentsApi::class) Debugger.KOOG_DEBUGGER_PORT_VM_OPTION
102101
val portEnvVarName = @OptIn(ExperimentalAgentsApi::class) Debugger.KOOG_DEBUGGER_PORT_ENV_VAR

agents/agents-core/src/jvmTest/kotlin/ai/koog/agents/core/system/feature/DebuggerStreamingTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,15 @@ import kotlinx.coroutines.joinAll
4646
import kotlinx.coroutines.launch
4747
import kotlinx.coroutines.runBlocking
4848
import kotlinx.coroutines.withTimeoutOrNull
49+
import org.junit.jupiter.api.Disabled
4950
import kotlin.test.Test
5051
import kotlin.test.assertContentEquals
5152
import kotlin.test.assertEquals
5253
import kotlin.test.assertFailsWith
5354
import kotlin.test.assertNotNull
5455
import kotlin.test.assertTrue
5556

57+
@Disabled("Flaky, see #1124")
5658
class DebuggerStreamingTest {
5759

5860
@Test

agents/agents-core/src/jvmTest/kotlin/ai/koog/agents/core/system/feature/DebuggerSubgraphTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import kotlinx.coroutines.joinAll
3131
import kotlinx.coroutines.launch
3232
import kotlinx.coroutines.runBlocking
3333
import kotlinx.coroutines.withTimeoutOrNull
34+
import org.junit.jupiter.api.Disabled
3435
import kotlin.reflect.typeOf
3536
import kotlin.test.Test
3637
import kotlin.test.assertContentEquals
@@ -39,6 +40,7 @@ import kotlin.test.assertFailsWith
3940
import kotlin.test.assertNotNull
4041
import kotlin.test.assertTrue
4142

43+
@Disabled("Flaky, see #1124")
4244
class DebuggerSubgraphTest {
4345

4446
@Test

agents/agents-core/src/jvmTest/kotlin/ai/koog/agents/core/system/feature/DebuggerTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ import ai.koog.agents.core.utils.SerializationUtils
4848
import ai.koog.agents.testing.network.NetUtil.findAvailablePort
4949
import ai.koog.agents.testing.tools.DummyTool
5050
import ai.koog.agents.testing.tools.getMockExecutor
51-
import ai.koog.integration.tests.utils.annotations.Retry
5251
import ai.koog.prompt.dsl.Prompt
5352
import ai.koog.prompt.llm.toModelInfo
5453
import ai.koog.prompt.message.Message
@@ -60,16 +59,17 @@ import kotlinx.coroutines.joinAll
6059
import kotlinx.coroutines.launch
6160
import kotlinx.coroutines.runBlocking
6261
import kotlinx.coroutines.withTimeoutOrNull
62+
import org.junit.jupiter.api.Disabled
6363
import kotlin.reflect.typeOf
6464
import kotlin.test.Test
6565
import kotlin.test.assertContentEquals
6666
import kotlin.test.assertEquals
6767
import kotlin.test.assertNotNull
6868
import kotlin.test.assertTrue
6969

70+
@Disabled("Flaky, see #1124")
7071
class DebuggerTest {
7172

72-
@Retry(3)
7373
@OptIn(InternalAgentsApi::class)
7474
@Test
7575
fun `test feature message remote writer collect events on agent run`() = runBlocking {

agents/agents-features/agents-features-trace/src/jvmTest/kotlin/ai/koog/agents/features/tracing/writer/TraceFeatureMessageRemoteWriterTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ import kotlinx.coroutines.runBlocking
6464
import kotlinx.coroutines.withTimeoutOrNull
6565
import kotlinx.io.IOException
6666
import kotlinx.serialization.json.JsonPrimitive
67+
import org.junit.jupiter.api.Disabled
6768
import org.junit.jupiter.api.parallel.Execution
6869
import org.junit.jupiter.api.parallel.ExecutionMode
6970
import kotlin.reflect.typeOf
@@ -75,6 +76,7 @@ import kotlin.test.assertNotNull
7576
import kotlin.test.assertTrue
7677
import kotlin.time.Duration.Companion.seconds
7778

79+
@Disabled("Flaky, see #1252")
7880
@Execution(ExecutionMode.SAME_THREAD)
7981
class TraceFeatureMessageRemoteWriterTest {
8082

0 commit comments

Comments
 (0)