Skip to content

Commit f936741

Browse files
authored
Fix failing integration tests (#1332)
<!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> - Skip Google LLMProvider because of a [bug](googleapis/python-genai#1723); - Adjust rollback test expectations after a [fix](#1308); - Update a QWEN profile used in OpenRouterModels to less flaky. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
1 parent 3a6d548 commit f936741

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

integration-tests/src/jvmTest/kotlin/ai/koog/integration/tests/agent/AIAgentIntegrationTest.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,13 @@ class AIAgentIntegrationTest : AIAgentTestBase() {
749749
shouldContain(saySaveLog.trim())
750750
shouldContain(sayByeLog.trim())
751751
shouldContain(rollbackPerformingLog.trim())
752-
saySaveLog.trim().toRegex().findAll(this).count() shouldBe 2
752+
// After #1308: checkpoint restoration doesn't re-execute the checkpointed node
753+
// nodeHello and nodeSave are executed once (no re-execution after rollback)
754+
sayHelloLog.trim().toRegex().findAll(this).count() shouldBe 1
755+
saySaveLog.trim().toRegex().findAll(this).count() shouldBe 1
756+
// one rollback should be performed and tracked
757+
rollbackPerformingLog.trim().toRegex().findAll(this).count() shouldBe 1
758+
// nodeBye is executed twice (once before rollback, once after rollback)
753759
sayByeLog.trim().toRegex().findAll(this).count() shouldBe 2
754760
}
755761
}

integration-tests/src/jvmTest/kotlin/ai/koog/integration/tests/capabilities/ModelCapabilitiesIntegrationTest.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,10 @@ class ModelCapabilitiesIntegrationTest {
236236
}
237237

238238
LLMCapability.MultipleChoices -> {
239+
assumeTrue(
240+
model.provider !is LLMProvider.Google,
241+
"https://github.com/googleapis/python-genai/issues/1723"
242+
)
239243
val prompt = prompt(
240244
"cap-multiple-choices-positive",
241245
params = LLMParams(numberOfChoices = 2)

integration-tests/src/jvmTest/kotlin/ai/koog/integration/tests/utils/Models.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ object Models {
4444
@JvmStatic
4545
fun openRouterModels(): Stream<LLModel> = Stream.of(
4646
OpenRouterModels.DeepSeekV30324,
47-
OpenRouterModels.Qwen3VL,
47+
OpenRouterModels.Qwen2_5,
4848
)
4949

5050
@JvmStatic

0 commit comments

Comments
 (0)