Remove publish logic duplication (#461)

* Move pom configuration to separate file

* Single publish conventions plugin

* Remove `sign` logic duplication

Author: turansky

buildSrc/src/main/kotlin/MavenPom.kt

@@ -0,0 +1,33 @@
+import org.gradle.api.Project
+import org.gradle.api.publish.maven.MavenPublication
+
+internal fun MavenPublication.configurePom(
+    project: Project
+) {
+    pom {
+        name.set(project.name)
+        description.set(project.description)
+        url.set("https://github.com/JetBrains/kotlin-wrappers")
+
+        licenses {
+            license {
+                name.set("The Apache License, Version 2.0")
+                url.set("http://www.apache.org/licenses/LICENSE-2.0.txt")
+            }
+        }
+
+        developers {
+            developer {
+                id.set("JetBrains")
+                name.set("Leonid Khachaturov")
+                email.set("[email protected]")
+            }
+        }
+
+        scm {
+            connection.set("scm:git:git://github.com/JetBrains/kotlin-wrappers.git")
+            developerConnection.set("scm:git:[email protected]:JetBrains/kotlin-wrappers.git")
+            url.set("https://github.com/JetBrains/kotlin-wrappers")
+        }
+    }
+}

buildSrc/src/main/kotlin/maven-publishing-conventions.gradle.kts renamed to buildSrc/src/main/kotlin/publish-conventions.gradle.kts

@@ -28,7 +28,7 @@ configure<PublishingExtension> {
                     if (name == "jvm")
                         artifact(javadocJar!!.get())
 
-                    metadata()
+                    configurePom(project)
                 }
 
             isKotlinJsProject ->
@@ -41,7 +41,7 @@ configure<PublishingExtension> {
 
                     artifact(tasks.getByName<Zip>("jsLegacySourcesJar"))
 
-                    metadata()
+                    configurePom(project)
                 }
         }
     }
@@ -55,31 +55,10 @@ configure<PublishingExtension> {
     }
 }
 
-fun MavenPublication.metadata() {
-    pom {
-        name.set(project.name)
-        description.set(project.description)
-        url.set("https://github.com/JetBrains/kotlin-wrappers")
+signing {
+    setRequired({
+        gradle.taskGraph.hasTask("publish")
+    })
 
-        licenses {
-            license {
-                name.set("The Apache License, Version 2.0")
-                url.set("http://www.apache.org/licenses/LICENSE-2.0.txt")
-            }
-        }
-
-        developers {
-            developer {
-                id.set("JetBrains")
-                name.set("Leonid Khachaturov")
-                email.set("[email protected]")
-            }
-        }
-
-        scm {
-            connection.set("scm:git:git://github.com/JetBrains/kotlin-wrappers.git")
-            developerConnection.set("scm:git:[email protected]:JetBrains/kotlin-wrappers.git")
-            url.set("https://github.com/JetBrains/kotlin-wrappers")
-        }
-    }
+    sign(publishing.publications)
 }

buildSrc/src/main/kotlin/publishing-conventions.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     kotlin("multiplatform")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 kotlin {
@@ -35,11 +35,3 @@ kotlin {
         }
     }
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-css/build.gradle.kts

@@ -1,12 +1,4 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-extensions/build.gradle.kts

@@ -1,16 +1,8 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
     api(npmv("mocha"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-mocha/build.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
@@ -11,11 +11,3 @@ dependencies {
 
     api(npmv("react-dom"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-react-dom/build.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
@@ -10,11 +10,3 @@ dependencies {
 
     api(npmv("react-redux"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-react-redux/build.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
@@ -9,11 +9,3 @@ dependencies {
 
     api(npmv("react-router-dom"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-react-router-dom/build.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
@@ -9,11 +9,3 @@ dependencies {
 
     api(npmv("react-table"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-react-table/build.gradle.kts

@@ -1,18 +1,10 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
     api(project(":kotlin-extensions"))
 
     api(npmv("react"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-react/build.gradle.kts

@@ -1,7 +1,7 @@
 plugins {
     kotlin("js")
     kotlin("plugin.serialization")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
@@ -10,11 +10,3 @@ dependencies {
 
     api(npmv("redux"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}

kotlin-redux/build.gradle.kts

@@ -1,6 +1,6 @@
 plugins {
     kotlin("js")
-    `publishing-conventions`
+    `publish-conventions`
 }
 
 dependencies {
@@ -15,11 +15,3 @@ dependencies {
     api(npm("inline-style-prefixer", "^6.0.0"))
     api(npm("styled-components", "^5.2.0"))
 }
-
-signing {
-    setRequired({
-        gradle.taskGraph.hasTask("publish")
-    })
-
-    sign(publishing.publications)
-}