Psi: Support auto property get set access modifiers (#1007)

Author: DedSec256

ReSharper.FSharp/src/FSharp/FSharp.Psi.Features/src/AICore/FSharpFileSummarizer.fs

@@ -78,16 +78,7 @@ type private FileSummarizerVisitor() =
     let addMember (memberDecl: IOverridableMemberDeclaration) (context: SummarizerContext) =
         let typeRepr = memberDecl.GetFcsSymbol() |> formatFcsSymbolType
         let accessorNames =
-            match memberDecl with
-            | :? IAccessorsNamesClauseOwner as prop ->
-                match prop.AccessorsClause with
-                | null -> Seq.empty
-                | clause -> clause.AccessorsNamesEnumerable |> Seq.map _.Name
-
-            | :? IMemberSignatureOrDeclaration as memberDecl ->
-                memberDecl.AccessorDeclarationsEnumerable |> Seq.map _.NameIdentifier.Name
-
-            | _ -> Seq.empty
+            memberDecl.AccessorDeclarations |> Seq.map _.AccessorName
 
         let accessors =
             if Seq.isEmpty accessorNames then "" else

ReSharper.FSharp/src/FSharp/FSharp.Psi.Features/src/LanguageService/FSharpElementFactory.fs

@@ -403,14 +403,14 @@ type FSharpElementFactory(languageService: IFSharpLanguageService, [<NotNull>] c
 
             typeDeclaration.TypeParameterDeclarationList
 
-        member this.CreateAccessorsNamesClause(withGetter, withSetter) =
+        member this.CreateAutoPropertyDeclaration(withGetter, withSetter) =
             let accessors = [|
                 if withGetter then "get"
                 if withSetter then "set" |] |> String.concat ", "
 
             let source = $"member val P = 3 with {accessors}"
             let t = getTypeDecl source
-            t.MemberDeclarations[0].As<IAutoPropertyDeclaration>().AccessorsClause
+            t.MemberDeclarations[0].As<IAutoPropertyDeclaration>()
 
         member this.CreateEmptyFile() = createFile ""
 

ReSharper.FSharp/src/FSharp/FSharp.Psi.Features/src/Parsing/FSharpImplTreeBuilder.fs

@@ -255,33 +255,26 @@ type FSharpImplTreeBuilder(lexer, document, decls, warnDirectives, lifetime, pat
             | SynMemberDefn.Member(binding, range) ->
                 x.ProcessMemberBinding(mark, binding, range, None)
 
-            | SynMemberDefn.AbstractSlot(SynValSig(explicitTypeParams = typeParams; synType = synType; arity = arity; trivia = trivia), _, range, _) ->
+            | SynMemberDefn.AbstractSlot(SynValSig(explicitTypeParams = typeParams; synType = synType; arity = arity; accessibility = accessibility), _, _, memberTrivia) ->
                 match typeParams with
                 | SynValTyparDecls(Some(typeParams), _) ->
                     x.ProcessTypeParameters(typeParams, false)
                 | _ -> ()
                 x.ProcessReturnTypeInfo(arity, synType)
-                x.ProcessAccessorsNamesClause(trivia, range)
+                x.ProcessImplicitAccessors(memberTrivia.GetSetKeywords, accessibility)
                 ElementType.ABSTRACT_MEMBER_DECLARATION
 
             | SynMemberDefn.ValField(SynField(fieldType = synType), _) ->
                 x.ProcessType(synType)
                 ElementType.VAL_FIELD_DECLARATION
 
-            | SynMemberDefn.AutoProperty(_, _, _, synTypeOpt, _, _, _, _, _, expr, _, accessorClause) ->
+            | SynMemberDefn.AutoProperty(_, _, _, synTypeOpt, _, _, _, _, accessibility, expr, _, accessorClause) ->
                 match synTypeOpt with
                 | Some synType -> x.ProcessType(synType)
                 | _ -> ()
-                x.MarkChameleonExpression(expr)
-
-                match accessorClause.WithKeyword, accessorClause.GetSetKeywords with
-                | Some withKeyword, None ->
-                    x.MarkAndDone(withKeyword, ElementType.ACCESSORS_NAMES_CLAUSE)
-                | Some withKeyword, Some getSetKeywords ->
-                    let range = Range.unionRanges withKeyword getSetKeywords.Range
-                    x.MarkAndDone(range, ElementType.ACCESSORS_NAMES_CLAUSE)
-                | _ -> ()
 
+                x.MarkChameleonExpression(expr)
+                x.ProcessImplicitAccessors(accessorClause.GetSetKeywords, accessibility)
                 ElementType.AUTO_PROPERTY_DECLARATION
 
             | _ -> failwithf "Unexpected type member: %A" typeMember

ReSharper.FSharp/src/FSharp/FSharp.Psi.Features/src/Parsing/FSharpTreeBuilderBase.fs

@@ -941,22 +941,47 @@ type FSharpTreeBuilderBase(lexer: ILexer, document: IDocument, warnDirectives: W
         x.MarkAndDone(range, ElementType.TYPE_PARAMETER_ID)
         x.Done(range, mark, ElementType.TYPE_REFERENCE_NAME)
 
-    member x.ProcessAccessorsNamesClause(trivia: SynValSigTrivia, memberRange) =
-        match trivia.WithKeyword with
+    member x.ProcessImplicitAccessors(getSetKeywords, accessibility) =
+        let processAccessor (access, nameRange: range) =
+            let mark =
+                match access with
+                | Some (access: SynAccess) -> x.Mark(access.Range)
+                | None -> x.Mark(nameRange)
+
+            x.Done(nameRange, mark, ElementType.ACCESSOR_DECLARATION)
+
+        let getAccess, setAccess =
+            match accessibility with
+            | SynValSigAccess.GetSet(_, getAccess, setAccess) -> getAccess, setAccess
+            | _ -> None, None
+
+        match getSetKeywords with
         | None -> ()
-        | Some withRange ->
+        | Some getSetKeywords ->
+
+        match getSetKeywords with
+        | GetSetKeywords.GetSet(getKeyword, setKeyword) ->
+            let getter = getAccess, getKeyword
+            let setter = setAccess, setKeyword
+
+            let accessor1, accessor2 =
+                if Range.rangeBeforePos getKeyword setKeyword.Start then getter, setter
+                else setter, getter
+
+            processAccessor accessor1
+            processAccessor accessor2
 
-        let accessorsMark = x.Mark(withRange)
-        x.Done(memberRange, accessorsMark, ElementType.ACCESSORS_NAMES_CLAUSE)
+        | GetSetKeywords.Get(get) -> processAccessor (getAccess, get)
+        | GetSetKeywords.Set(set) -> processAccessor (setAccess, set)
 
     member x.ProcessTypeMemberSignature(memberSig) =
         match memberSig with
-        | SynMemberSig.Member(SynValSig(attrs, _, _, synType, arity, _, _, XmlDoc xmlDoc, _, _, _, trivia), flags, range, _) ->
+        | SynMemberSig.Member(SynValSig(attrs, _, _, synType, arity, _, _, XmlDoc xmlDoc, accessibility, _, _, _), flags, range, memberTrivia) ->
             let mark = x.MarkAndProcessIntro(attrs, xmlDoc, null, range)
             x.ProcessReturnTypeInfo(arity, synType)
             let elementType =
                 if flags.IsDispatchSlot then
-                    x.ProcessAccessorsNamesClause(trivia, range)
+                    x.ProcessImplicitAccessors(memberTrivia.GetSetKeywords, accessibility)
                     ElementType.ABSTRACT_MEMBER_DECLARATION
                 else
                     match flags.MemberKind with

ReSharper.FSharp/src/FSharp/FSharp.Psi.Intentions/src/QuickFixes/AddSetterFix.fs

@@ -2,16 +2,24 @@ namespace JetBrains.ReSharper.Plugins.FSharp.Psi.Features.Daemon.QuickFixes
 
 open JetBrains.ReSharper.Plugins.FSharp.Psi
 open JetBrains.ReSharper.Plugins.FSharp.Psi.Features.Daemon.Highlightings
-open JetBrains.ReSharper.Plugins.FSharp.Psi.Impl.Tree
+open JetBrains.ReSharper.Plugins.FSharp.Psi.Parsing
 open JetBrains.ReSharper.Plugins.FSharp.Psi.Tree
-open JetBrains.ReSharper.Psi.ExtensionsAPI
+open JetBrains.ReSharper.Psi
+open JetBrains.ReSharper.Psi.ExtensionsAPI.Tree
+open JetBrains.ReSharper.Psi.Tree
 open JetBrains.ReSharper.Resources.Shell
 
 type AddSetterFix(error: PropertyCannotBeSetError) =
     inherit FSharpQuickFixBase()
 
     let refExpr = error.RefExpr
-    let mutable declaration: IAccessorsNamesClauseOwner = null
+    let mutable declaration: IOverridableMemberDeclaration = null
+
+    let setterNodes setter: ITreeNode list =
+        [ FSharpTokenType.COMMA.CreateLeafElement(); setter ]
+
+    let getSetNodes getter setter: ITreeNode list =
+        [ FSharpTokenType.WITH.CreateLeafElement(); getter ] @ setterNodes setter
 
     override this.IsAvailable _ =
         isValid refExpr &&
@@ -26,20 +34,29 @@ type AddSetterFix(error: PropertyCannotBeSetError) =
 
         declaration <-
             match decl with
-            | :? IAbstractMemberDeclaration as decl -> decl :> IAccessorsNamesClauseOwner
+            | :? IAbstractMemberDeclaration as decl -> decl :> IOverridableMemberDeclaration
             | :? IAutoPropertyDeclaration as decl when not decl.IsVirtual -> decl
             | _ -> null
 
-        isNotNull declaration
+        isNotNull declaration &&
+
+        let accessors = declaration.AccessorDeclarations
+        accessors.All _.IsImplicit
 
     override this.Text = $"Add setter to '{refExpr.ShortName}'"
 
     override this.ExecutePsiTransaction _ =
         use writeCookie = WriteLockCookie.Create(refExpr.IsPhysical())
 
         let factory = refExpr.CreateElementFactory()
-        let accessors = factory.CreateAccessorsNamesClause(true, true)
+        let createGetter = isNull (declaration.GetAccessor(AccessorKind.GETTER))
+        let autoProperty = factory.CreateAutoPropertyDeclaration(createGetter, true)
+        let accessors = autoProperty.AccessorDeclarationsEnumerable |> Seq.toList
+
+        let nodesToAdd =
+            match accessors with
+            | [getter; setter] -> getSetNodes getter setter
+            | [setter] -> setterNodes setter
+            | _ -> []
 
-        declaration.SetAccessorsClause(accessors) |> ignore
-        if not (declaration.AccessorsClause.PrevSibling :? Whitespace) then
-            addNodeBefore declaration.AccessorsClause (Whitespace(1))
+        addNodesAfter declaration.LastChild nodesToAdd |> ignore

ReSharper.FSharp/src/FSharp/FSharp.Psi/src/FSharp.psi

@@ -1446,7 +1446,7 @@ abstractMemberDeclaration options { stubBase="FSharpProperTypeMemberDeclarationB
   identOrOpName{IDENTIFIER, Identifier}
   postfixTypeParameterDeclarationList<TYPE_PARAMETER_LIST, TypeParameterList>?
   returnTypeInfo<RETURN_INFO, ReturnTypeInfo>
-  accessorsNamesClause<ACESSORS_CLAUSE, AccessorsClause>?;
+  accessorDecls?;
 
 valFieldDeclaration options { stubBase="FSharpProperTypeMemberDeclarationBase"; } extras {
   get { methodName="Attributes" path=<valFieldDeclaration:ATTRIBUTE_LIST/attributeList:ATTRIBUTE> };
@@ -1475,17 +1475,7 @@ autoPropertyDeclaration options { stubBase="FSharpProperTypeMemberDeclarationBas
   )?
   EQUALS<FSHARP_EQUALS, EqualsToken>
   chameleonExpression<CHAMELEON_EXPR, InitExpression>
-  accessorsNamesClause<ACESSORS_CLAUSE, AccessorsClause>?;
-
-accessorsNamesClause:
-  WITH
-  (
-    fSharpIdentifier<ACESSOR, AccessorsNames>
-  |
-    fSharpIdentifier<ACESSOR, AccessorsNames>
-    COMMA<FSHARP_COMMA, Comma>
-    fSharpIdentifier<ACESSOR, AccessorsNames>
-  );
+  accessorDecls?;
 
 accessorDeclaration options { stubBase="FSharpProperTypeMemberDeclarationBase"; } extras {
   get { methodName="Expression" path=<accessorDeclaration:CHAMELEON_EXPR/chameleonExpression:EXPR> };

ReSharper.FSharp/src/FSharp/FSharp.Psi/src/IFSharpElementFactory.cs

@@ -65,7 +65,7 @@ public interface IFSharpElementFactory
 
     ITypeParameterDeclarationList CreateTypeParameterOfTypeList(FSharpList<string> names);
 
-    IAccessorsNamesClause CreateAccessorsNamesClause(bool withGetter, bool withSetter);
+    IAutoPropertyDeclaration CreateAutoPropertyDeclaration(bool withGetter, bool withSetter);
 
     IFSharpFile CreateEmptyFile();
     INamedModuleDeclaration CreateModule(string name);

ReSharper.FSharp/src/FSharp/FSharp.Psi/src/Impl/DeclaredElement/FSharpMemberBase.cs

@@ -56,23 +56,16 @@ public override AccessRights GetAccessRights()
       if (IsExplicitImplementation)
         return AccessRights.PRIVATE;
 
+      var declaration = GetDeclaration();
+
       // Workaround to hide extension methods from resolve in C#.
       // todo: calc compiled names for extension members (it'll hide needed ones properly)
       // todo: implement F# declared element presenter to hide compiled names in features/ui
-      if (IsFSharpExtensionMember && GetDeclaration() is IMemberSignatureOrDeclaration memberDeclaration)
+      if (IsFSharpExtensionMember && declaration is IMemberSignatureOrDeclaration memberDeclaration)
         if (!(this is IMethod && memberDeclaration.Attributes.GetCompiledName(out _)))
           return AccessRights.INTERNAL;
 
-      var mfv = Mfv;
-      if (mfv == null)
-        return AccessRights.NONE;
-
-      var accessibility = mfv.Accessibility;
-      if (accessibility.IsInternal)
-        return AccessRights.INTERNAL;
-      if (accessibility.IsPrivate)
-        return AccessRights.PRIVATE;
-      return AccessRights.PUBLIC;
+      return declaration?.GetAccessRights() ?? AccessRights.NONE;
     }
 
     public override bool IsStatic => !Mfv?.IsInstanceMember ?? false;

ReSharper.FSharp/src/FSharp/FSharp.Psi/src/Impl/DeclaredElement/FSharpProperty.cs

@@ -11,7 +11,7 @@ internal class FSharpProperty<TDeclaration>(
     [NotNull] ITypeMemberDeclaration declaration,
     [NotNull] FSharpMemberOrFunctionOrValue mfv)
     : FSharpPropertyMemberBase<TDeclaration>(declaration, mfv), IFSharpProperty
-    where TDeclaration : IFSharpDeclaration, IModifiersOwnerDeclaration, ITypeMemberDeclaration
+    where TDeclaration : IOverridableMemberDeclaration
   {
     public override bool IsStatic => GetContainingType() is IFSharpModule || base.IsStatic;
 

ReSharper.FSharp/src/FSharp/FSharp.Psi/src/Impl/DeclaredElement/FSharpPropertyBase.cs

@@ -6,14 +6,13 @@
 using JetBrains.ReSharper.Plugins.FSharp.Psi.Tree;
 using JetBrains.ReSharper.Plugins.FSharp.Psi.Util;
 using JetBrains.ReSharper.Psi;
-using JetBrains.ReSharper.Psi.Impl.Special;
 using JetBrains.ReSharper.Psi.Resolve;
 using JetBrains.ReSharper.Psi.Tree;
 
 namespace JetBrains.ReSharper.Plugins.FSharp.Psi.Impl.DeclaredElement
 {
   internal abstract class FSharpPropertyMemberBase<TDeclaration> : FSharpPropertyBase<TDeclaration>
-    where TDeclaration : IFSharpDeclaration, IModifiersOwnerDeclaration, ITypeMemberDeclaration
+    where TDeclaration : IOverridableMemberDeclaration
   {
     protected FSharpPropertyMemberBase([NotNull] ITypeMemberDeclaration declaration,
       [NotNull] FSharpMemberOrFunctionOrValue mfv) : base(declaration)
@@ -82,7 +81,7 @@ bool IsReadable(FSharpMemberOrFunctionOrValue mfv) =>
 
   internal abstract class FSharpPropertyBase<TDeclaration>([NotNull] ITypeMemberDeclaration declaration)
     : FSharpMemberBase<TDeclaration>(declaration), IFSharpParameterOwnerMember, IProperty
-    where TDeclaration : IFSharpDeclaration, IModifiersOwnerDeclaration, ITypeMemberDeclaration
+    where TDeclaration : IOverridableMemberDeclaration
   {
     protected override FSharpSymbol GetActualSymbol(FSharpSymbol symbol)
     {
@@ -124,8 +123,8 @@ public override DeclaredElementType GetElementType() =>
 
     public string GetDefaultPropertyMetadataName() => ShortName;
 
-    public IAccessor Getter => IsReadable ? new ImplicitAccessor(this, AccessorKind.GETTER) : null;
-    public IAccessor Setter => IsWritable ? new ImplicitAccessor(this, AccessorKind.SETTER) : null;
+    public IAccessor Getter => IsReadable ? new FSharpPropertyImplicitAccessor(this, AccessorKind.GETTER) : null;
+    public IAccessor Setter => IsWritable ? new FSharpPropertyImplicitAccessor(this, AccessorKind.SETTER) : null;
 
     public abstract bool IsReadable { get; }
     public abstract bool IsWritable { get; }