[unity] Replace RdProperty with Property since the usage is not RD/connection

(cherry picked from commit ac4e97b833877f2a27e58f06d2a61251453f7498)

IJ-CR-181766

GitOrigin-RevId: 26c7b07f87cf1d73ca2a4bcd4be7f2547e62f1f1

Author: van800

rider/src/main/kotlin/com/jetbrains/rider/plugins/unity/UnityProjectDiscoverer.kt

@@ -10,6 +10,7 @@ import com.jetbrains.rd.framework.impl.RdProperty
 import com.jetbrains.rd.ide.model.RdExistingSolution
 import com.jetbrains.rd.protocol.SolutionExtListener
 import com.jetbrains.rd.util.lifetime.Lifetime
+import com.jetbrains.rd.util.reactive.Property
 import com.jetbrains.rd.util.reactive.adviseUntil
 import com.jetbrains.rd.util.threading.coroutines.launch
 import com.jetbrains.rider.plugins.unity.explorer.UnityExplorer
@@ -23,7 +24,7 @@ import kotlinx.coroutines.withContext
 
 class UnityDetectorImpl(private val project: Project) : UnityDetector {
 
-    override val isUnitySolution: RdProperty<Boolean>
+    override val isUnitySolution: Property<Boolean>
         get() = UnityProjectDiscoverer.getInstance(project).isUnityProject
 }
 
@@ -32,8 +33,7 @@ class UnityProjectDiscoverer(val project: Project) {
     // These values will be false unless we've opened a .sln file. Note that the "sidecar" project is a solution that
     // lives in the same folder as generated unity project (not the same as a class library project, which could live
     // anywhere)
-    // todo: switch to Property, after RIDER-132142 fixed, https://jetbrains.team/p/ij/reviews/181766/timeline
-    val isUnityProject = RdProperty(UnityProjectDiscovererState.getInstance(project).isUnityProjectState)
+    val isUnityProject = Property(UnityProjectDiscovererState.getInstance(project).isUnityProjectState)
 
     // It's a Unity project, but not necessarily loaded correctly (e.g. it might be opened as folder)
     val isUnityProjectFolder = RdProperty(UnityProjectDiscovererState.getInstance(project).isUnityProjectFolderState)
@@ -144,7 +144,7 @@ class UnityProjectDiscoverer(val project: Project) {
 
 val Project.hasUnityReference: RdProperty<Boolean>
     get() = UnityProjectDiscoverer.getInstance(this).hasUnityReference
-val Project.isUnityProject: RdProperty<Boolean>
+val Project.isUnityProject: Property<Boolean>
     get() = UnityProjectDiscoverer.getInstance(this).isUnityProject
 val Project.isUnityProjectFolder: RdProperty<Boolean>
     get() = UnityProjectDiscoverer.getInstance(this).isUnityProjectFolder

rider/src/main/kotlin/com/jetbrains/rider/plugins/unity/actions/ActionUtils.kt

@@ -3,6 +3,7 @@ package com.jetbrains.rider.plugins.unity.actions
 import com.intellij.openapi.actionSystem.AnActionEvent
 import com.intellij.ui.ExperimentalUI
 import com.jetbrains.rd.framework.impl.RdProperty
+import com.jetbrains.rd.util.reactive.Property
 import com.jetbrains.rider.plugins.unity.isConnectedToEditor
 import com.jetbrains.rider.plugins.unity.isUnityProject
 import com.jetbrains.rider.plugins.unity.isUnityProjectFolder
@@ -15,7 +16,7 @@ fun AnActionEvent.getFrontendBackendModel(): FrontendBackendModel? {
     return project.solution.frontendBackendModel
 }
 
-val AnActionEvent.isUnityProject: RdProperty<Boolean>?
+val AnActionEvent.isUnityProject: Property<Boolean>?
     get() = project?.isUnityProject
 
 val AnActionEvent.isUnityProjectFolder: RdProperty<Boolean>?
@@ -27,6 +28,12 @@ val RdProperty<Boolean>?.valueOrDefault: Boolean
         return this.value
     }
 
+val Property<Boolean>?.valueOrDefault: Boolean
+    get() {
+        if (this == null) return false
+        return this.value
+    }
+
 fun AnActionEvent.handleUpdateForUnityConnection(update: ((FrontendBackendModel) -> Boolean)? = null) {
     if (!isUnityProject.valueOrDefault && !ExperimentalUI.isNewUI()) { // do not hide UnityActions in the toolbar for the new UI
         presentation.isVisible = false