Fix order-dependent pitch comparison in tied chords (sugarlabs#5254)

* pitch comparison for tied chords

* chore: retrigger CI

* chore: retrigger CI

* chore: format js/turtle-singer.js with CI Prettier

Author: kartikktripathi

js/turtle-singer.js

@@ -1592,19 +1592,25 @@ class Singer {
                     ) {
                         match = false;
                     } else {
-                        /**
-                         * @todo FIXME: This check assumes that the order of the pitch blocks in a chord are the same
-                         */
-                        for (let i = 0; i < tur.singer.tieNotePitches.length; i++) {
-                            if (
-                                tur.singer.tieNotePitches[i][0] !=
-                                    tur.singer.notePitches[last(tur.singer.inNoteBlock)][i] ||
-                                tur.singer.tieNotePitches[i][1] !=
-                                    tur.singer.noteOctaves[last(tur.singer.inNoteBlock)][i]
-                            ) {
-                                match = false;
-                                break;
-                            }
+                        // Compare tied chords in an order-independent way (pitch, octave, cents)
+                        const normalizeChord = chord =>
+                            chord.map(p => `${p[0]}:${p[1]}:${p[2]}`).sort();
+
+                        const tiedChord = normalizeChord(tur.singer.tieNotePitches);
+
+                        const currentChord = normalizeChord(
+                            tur.singer.notePitches[last(tur.singer.inNoteBlock)].map((p, i) => [
+                                p,
+                                tur.singer.noteOctaves[last(tur.singer.inNoteBlock)][i],
+                                tur.singer.noteCents[last(tur.singer.inNoteBlock)][i]
+                            ])
+                        );
+
+                        if (
+                            tiedChord.length !== currentChord.length ||
+                            !tiedChord.every((v, i) => v === currentChord[i])
+                        ) {
+                            match = false;
                         }
                     }
 
@@ -2054,8 +2060,9 @@ class Singer {
                         0,
                         null
                     );
-                    const pitchNumber = getTemperament(activity.logo.synth.inTemperament)
-                        .pitchNumber;
+                    const pitchNumber = getTemperament(
+                        activity.logo.synth.inTemperament
+                    ).pitchNumber;
                     const ratio = [];
                     const number = [];
                     const numerator = [];