Skip to content

Commit 232695d

Browse files
committed
decouple the admin and api modules
Signed-off-by: Jin Hai <haijin.chn@gmail.com>
1 parent 9fed1e5 commit 232695d

File tree

3 files changed

+22
-23
lines changed

3 files changed

+22
-23
lines changed

admin/server/auth.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@
3131
from api.utils.crypt import decrypt
3232
from common.misc_utils import get_uuid
3333
from common.time_utils import current_timestamp, datetime_format, get_format_time
34-
from api.utils.api_utils import (
35-
construct_response,
36-
)
34+
from common.connection_utils import construct_response
3735

3836

3937
def setup_auth(login_manager):

api/utils/api_utils.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
from flask import (
2828
Response,
2929
jsonify,
30-
make_response,
3130
)
3231
from flask_login import current_user
3332
from flask import (
@@ -194,25 +193,6 @@ def build_error_result(code=RetCode.FORBIDDEN, message="success"):
194193
return response
195194

196195

197-
def construct_response(code=RetCode.SUCCESS, message="success", data=None, auth=None):
198-
result_dict = {"code": code, "message": message, "data": data}
199-
response_dict = {}
200-
for key, value in result_dict.items():
201-
if value is None and key != "code":
202-
continue
203-
else:
204-
response_dict[key] = value
205-
response = make_response(jsonify(response_dict))
206-
if auth:
207-
response.headers["Authorization"] = auth
208-
response.headers["Access-Control-Allow-Origin"] = "*"
209-
response.headers["Access-Control-Allow-Method"] = "*"
210-
response.headers["Access-Control-Allow-Headers"] = "*"
211-
response.headers["Access-Control-Allow-Headers"] = "*"
212-
response.headers["Access-Control-Expose-Headers"] = "Authorization"
213-
return response
214-
215-
216196
def construct_json_result(code: RetCode = RetCode.SUCCESS, message="success", data=None):
217197
if data is None:
218198
return jsonify({"code": code, "message": message})

common/connection_utils.py

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import asyncio
2222
import trio
2323
from functools import wraps
24+
from flask import make_response, jsonify
25+
from common.contants import RetCode
2426

2527
TimeoutException = Union[Type[BaseException], BaseException]
2628
OnTimeoutCallback = Union[Callable[..., Any], Coroutine[Any, Any, Any]]
@@ -99,3 +101,22 @@ async def async_wrapper(*args, **kwargs) -> Any:
99101
return wrapper
100102

101103
return decorator
104+
105+
106+
def construct_response(code=RetCode.SUCCESS, message="success", data=None, auth=None):
107+
result_dict = {"code": code, "message": message, "data": data}
108+
response_dict = {}
109+
for key, value in result_dict.items():
110+
if value is None and key != "code":
111+
continue
112+
else:
113+
response_dict[key] = value
114+
response = make_response(jsonify(response_dict))
115+
if auth:
116+
response.headers["Authorization"] = auth
117+
response.headers["Access-Control-Allow-Origin"] = "*"
118+
response.headers["Access-Control-Allow-Method"] = "*"
119+
response.headers["Access-Control-Allow-Headers"] = "*"
120+
response.headers["Access-Control-Allow-Headers"] = "*"
121+
response.headers["Access-Control-Expose-Headers"] = "Authorization"
122+
return response

0 commit comments

Comments
 (0)