fix

Author: JingsongLi

paimon-format/src/main/java/org/apache/paimon/format/orc/reader/AbstractOrcColumnVector.java

@@ -60,11 +60,6 @@ public boolean isNullAt(int i) {
         return !vector.noNulls && vector.isNull[rowMapper(i)];
     }
 
-    public static org.apache.paimon.data.columnar.ColumnVector createPaimonVector(
-            ColumnVector vector, VectorizedRowBatch orcBatch, DataType dataType) {
-        return createPaimonVector(vector, orcBatch, dataType, false);
-    }
-
     public static org.apache.paimon.data.columnar.ColumnVector createPaimonVector(
             ColumnVector vector,
             VectorizedRowBatch orcBatch,
@@ -86,12 +81,19 @@ public static org.apache.paimon.data.columnar.ColumnVector createPaimonVector(
             return new OrcTimestampColumnVector(vector, orcBatch, dataType, legacyTimestampLtzType);
         } else if (vector instanceof ListColumnVector) {
             return new OrcArrayColumnVector(
-                    (ListColumnVector) vector, orcBatch, (ArrayType) dataType);
+                    (ListColumnVector) vector,
+                    orcBatch,
+                    (ArrayType) dataType,
+                    legacyTimestampLtzType);
         } else if (vector instanceof StructColumnVector) {
             return new OrcRowColumnVector(
-                    (StructColumnVector) vector, orcBatch, (RowType) dataType);
+                    (StructColumnVector) vector,
+                    orcBatch,
+                    (RowType) dataType,
+                    legacyTimestampLtzType);
         } else if (vector instanceof MapColumnVector) {
-            return new OrcMapColumnVector((MapColumnVector) vector, orcBatch, (MapType) dataType);
+            return new OrcMapColumnVector(
+                    (MapColumnVector) vector, orcBatch, (MapType) dataType, legacyTimestampLtzType);
         } else {
             throw new UnsupportedOperationException(
                     "Unsupported vector: " + vector.getClass().getName());

paimon-format/src/main/java/org/apache/paimon/format/orc/reader/OrcArrayColumnVector.java

@@ -34,10 +34,15 @@ public class OrcArrayColumnVector extends AbstractOrcColumnVector
     private final ColumnVector paimonVector;
 
     public OrcArrayColumnVector(
-            ListColumnVector hiveVector, VectorizedRowBatch orcBatch, ArrayType type) {
+            ListColumnVector hiveVector,
+            VectorizedRowBatch orcBatch,
+            ArrayType type,
+            boolean legacyTimestampLtzType) {
         super(hiveVector, orcBatch);
         this.hiveVector = hiveVector;
-        this.paimonVector = createPaimonVector(hiveVector.child, orcBatch, type.getElementType());
+        this.paimonVector =
+                createPaimonVector(
+                        hiveVector.child, orcBatch, type.getElementType(), legacyTimestampLtzType);
     }
 
     @Override

paimon-format/src/main/java/org/apache/paimon/format/orc/reader/OrcMapColumnVector.java

@@ -35,12 +35,18 @@ public class OrcMapColumnVector extends AbstractOrcColumnVector
     private final ColumnVector valuePaimonVector;
 
     public OrcMapColumnVector(
-            MapColumnVector hiveVector, VectorizedRowBatch orcBatch, MapType type) {
+            MapColumnVector hiveVector,
+            VectorizedRowBatch orcBatch,
+            MapType type,
+            boolean legacyTimestampLtzType) {
         super(hiveVector, orcBatch);
         this.hiveVector = hiveVector;
-        this.keyPaimonVector = createPaimonVector(hiveVector.keys, orcBatch, type.getKeyType());
+        this.keyPaimonVector =
+                createPaimonVector(
+                        hiveVector.keys, orcBatch, type.getKeyType(), legacyTimestampLtzType);
         this.valuePaimonVector =
-                createPaimonVector(hiveVector.values, orcBatch, type.getValueType());
+                createPaimonVector(
+                        hiveVector.values, orcBatch, type.getValueType(), legacyTimestampLtzType);
     }
 
     @Override

paimon-format/src/main/java/org/apache/paimon/format/orc/reader/OrcRowColumnVector.java

@@ -33,13 +33,20 @@ public class OrcRowColumnVector extends AbstractOrcColumnVector
     private final VectorizedColumnBatch batch;
 
     public OrcRowColumnVector(
-            StructColumnVector hiveVector, VectorizedRowBatch orcBatch, RowType type) {
+            StructColumnVector hiveVector,
+            VectorizedRowBatch orcBatch,
+            RowType type,
+            boolean legacyTimestampLtzType) {
         super(hiveVector, orcBatch);
         int len = hiveVector.fields.length;
         ColumnVector[] paimonVectors = new ColumnVector[len];
         for (int i = 0; i < len; i++) {
             paimonVectors[i] =
-                    createPaimonVector(hiveVector.fields[i], orcBatch, type.getTypeAt(i));
+                    createPaimonVector(
+                            hiveVector.fields[i],
+                            orcBatch,
+                            type.getTypeAt(i),
+                            legacyTimestampLtzType);
         }
         this.batch = new VectorizedColumnBatch(paimonVectors);
     }

paimon-format/src/main/java/org/apache/paimon/format/orc/writer/RowDataVectorizer.java

@@ -34,10 +34,6 @@ public class RowDataVectorizer extends Vectorizer<InternalRow> {
 
     private final List<FieldWriter> fieldWriters;
 
-    public RowDataVectorizer(TypeDescription schema, DataType[] fieldTypes) {
-        this(schema, fieldTypes, false);
-    }
-
     public RowDataVectorizer(
             TypeDescription schema, DataType[] fieldTypes, boolean legacyTimestampLtzType) {
         super(schema);

paimon-format/src/test/java/org/apache/paimon/format/orc/OrcReaderFactoryTest.java

@@ -279,14 +279,7 @@ protected OrcReaderFactory createFormat(
                 conjunctPredicates,
                 BATCH_SIZE,
                 false,
-                false);
-    }
-
-    private RecordReader<InternalRow> createReader(OrcReaderFactory format, Path split)
-            throws IOException {
-        LocalFileIO fileIO = new LocalFileIO();
-        return format.createReader(
-                new FormatReaderContext(fileIO, split, fileIO.getFileSize(split)));
+                true);
     }
 
     private void forEach(OrcReaderFactory format, Path file, Consumer<InternalRow> action)

paimon-format/src/test/java/org/apache/paimon/format/orc/OrcWriterFactoryTest.java

@@ -49,7 +49,8 @@ void testNotOverrideInMemoryManager(@TempDir java.nio.file.Path tmpDir) throws I
                 new TestOrcWriterFactory(
                         new RowDataVectorizer(
                                 TypeDescription.fromString("struct<_col0:string,_col1:int>"),
-                                new DataType[] {DataTypes.STRING(), DataTypes.INT()}),
+                                new DataType[] {DataTypes.STRING(), DataTypes.INT()},
+                                true),
                         memoryManager);
         factory.create(new LocalPositionOutputStream(tmpDir.resolve("file1").toFile()), "LZ4");
         factory.create(new LocalPositionOutputStream(tmpDir.resolve("file2").toFile()), "LZ4");