Skip to content

Commit 41cf5cc

Browse files
committed
fix
1 parent 5f0c53e commit 41cf5cc

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

paimon-python/dev/run_mixed_tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,8 @@ main() {
343343

344344
echo ""
345345

346+
echo -e "${YELLOW}=== Test Results Summary ===${NC}"
347+
346348
if [[ $java_write_result -eq 0 ]]; then
347349
echo -e "${GREEN}✓ Java Write Test (Parquet/Orc/Avro + Lance): PASSED${NC}"
348350
else

paimon-python/pypaimon/table/source/full_text_read.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,8 @@ def _eval(self, row_range_start, row_range_end, full_text_index_files
9595

9696
reader = _create_full_text_reader(
9797
index_type, file_io, index_path,
98-
index_io_meta_list, self._text_column
98+
index_io_meta_list
9999
)
100-
if reader is None:
101-
return None
102100

103101
full_text_search = FullTextSearch(
104102
query_text=self._query_text,
@@ -113,7 +111,7 @@ def _eval(self, row_range_start, row_range_end, full_text_index_files
113111
reader.close()
114112

115113

116-
def _create_full_text_reader(index_type, file_io, index_path, index_io_meta_list, field):
114+
def _create_full_text_reader(index_type, file_io, index_path, index_io_meta_list):
117115
"""Create a global index reader for full-text search."""
118116
from pypaimon.globalindex.tantivy.tantivy_full_text_global_indexer import (
119117
TANTIVY_FULLTEXT_IDENTIFIER,

paimon-python/pypaimon/table/source/full_text_scan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def scan(self) -> FullTextScanPlan:
6262
text_column = self._text_column
6363
snapshot = SnapshotManager(self._table).get_latest_snapshot()
6464

65-
# Try time travel
65+
# Try time travel (optional, module may not be available)
6666
try:
6767
from pypaimon.snapshot.time_travel_util import TimeTravelUtil
6868
from pypaimon.common.options.options import Options
@@ -72,7 +72,7 @@ def scan(self) -> FullTextScanPlan:
7272
)
7373
if travel_snapshot is not None:
7474
snapshot = travel_snapshot
75-
except Exception:
75+
except ImportError:
7676
pass
7777

7878
index_file_handler = IndexFileHandler(table=self._table)

paimon-python/pypaimon/table/source/full_text_search_builder.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,17 @@ def with_query_text(self, query_text: str) -> 'FullTextSearchBuilder':
8888
return self
8989

9090
def new_full_text_scan(self) -> FullTextScan:
91-
assert self._text_column is not None, \
92-
"Text column must be set via with_text_column()"
91+
if self._text_column is None:
92+
raise ValueError("Text column must be set via with_text_column()")
9393
return FullTextScanImpl(self._table, self._text_column)
9494

9595
def new_full_text_read(self) -> FullTextRead:
96-
assert self._limit > 0, \
97-
"Limit must be positive, set via with_limit()"
98-
assert self._text_column is not None, \
99-
"Text column must be set via with_text_column()"
100-
assert self._query_text is not None, \
101-
"Query text must be set via with_query_text()"
96+
if self._limit <= 0:
97+
raise ValueError("Limit must be positive, set via with_limit()")
98+
if self._text_column is None:
99+
raise ValueError("Text column must be set via with_text_column()")
100+
if self._query_text is None:
101+
raise ValueError("Query text must be set via with_query_text()")
102102
return FullTextReadImpl(
103103
self._table, self._limit, self._text_column, self._query_text
104104
)

0 commit comments

Comments
 (0)