feat: CI fail-fast gating and post-test light teardown (#709)

Two improvements:

1. CI: lint and dependency-check now gate the test matrix. If either
   fails, test-core and test-cli are skipped rather than burning 18
   matrix slots on code that won't pass review anyway.

2. Tests: session-scoped autouse fixture turns off all connected
   lights after the test session completes. Prevents lights
   activated during tests from staying on.

Authored by Jny

Author: JnyJny

.github/workflows/ci.yml

@@ -52,8 +52,12 @@ jobs:
 
   test-core:
     name: "Core: Tests (${{ matrix.python-version }}, ${{ matrix.os }})"
-    needs: [detect-changes, get-python-versions]
-    if: needs.detect-changes.outputs.core == 'true'
+    needs: [detect-changes, get-python-versions, lint, dependency-check]
+    if: |
+      always()
+      && needs.detect-changes.outputs.core == 'true'
+      && needs.lint.result == 'success'
+      && (needs.dependency-check.result == 'success' || needs.dependency-check.result == 'skipped')
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -84,8 +88,12 @@ jobs:
 
   test-cli:
     name: "CLI: Tests (${{ matrix.python-version }}, ${{ matrix.os }})"
-    needs: [detect-changes, get-python-versions]
-    if: needs.detect-changes.outputs.cli == 'true' || needs.detect-changes.outputs.core == 'true'
+    needs: [detect-changes, get-python-versions, lint, dependency-check]
+    if: |
+      always()
+      && (needs.detect-changes.outputs.cli == 'true' || needs.detect-changes.outputs.core == 'true')
+      && needs.lint.result == 'success'
+      && (needs.dependency-check.result == 'success' || needs.dependency-check.result == 'skipped')
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false

packages/busylight-core/tests/conftest.py

@@ -1,9 +1,12 @@
 """Test configuration and shared fixtures."""
 
+import gc
+
 import pytest
 from serial.tools.list_ports_common import ListPortInfo
 
 from busylight_core.hardware import Hardware
+from busylight_core.light import Light
 
 
 @pytest.fixture
@@ -89,3 +92,22 @@ def hardware_devices(
     :return: List containing both mock Hardware instances
     """
     return [hardware_hid_device, hardware_serial_device]
+
+
+@pytest.fixture(autouse=True, scope="session")
+def turn_off_lights_after_tests() -> None:
+    """Turn off all connected lights after the test session completes.
+
+    Finds any Light instances left open by tests and turns them off
+    before releasing their hardware handles.
+    """
+    yield  # type: ignore[misc]
+
+    gc.collect()
+    for obj in gc.get_objects():
+        try:
+            if isinstance(obj, Light) and obj.hardware.is_acquired:
+                obj.off()
+                obj.release()
+        except Exception:  # noqa: S110
+            pass

packages/busylight/tests/conftest.py

@@ -1 +1,26 @@
-""" """
+"""Test configuration and shared fixtures."""
+
+import gc
+
+import pytest
+
+from busylight_core.light import Light
+
+
+@pytest.fixture(autouse=True, scope="session")
+def turn_off_lights_after_tests() -> None:
+    """Turn off all connected lights after the test session completes.
+
+    Finds any Light instances left open by tests and turns them off
+    before releasing their hardware handles.
+    """
+    yield  # type: ignore[misc]
+
+    gc.collect()
+    for obj in gc.get_objects():
+        try:
+            if isinstance(obj, Light) and obj.hardware.is_acquired:
+                obj.off()
+                obj.release()
+        except Exception:  # noqa: S110
+            pass