Merge pull request #1093 from JoinColony/maint/slither

Exclude new mostly inappropriate slither detectors

Author: kronosapiens

contracts/colony/ColonyFunding.sol

@@ -475,6 +475,7 @@ contract ColonyFunding is ColonyStorage { // ignore-swc-123
       }
     }
 
+    // slither-disable-next-line reentrancy-unlimited-gas
     emit PayoutClaimed(msgSender(), _fundingPotId, _token, remainder);
   }
 

contracts/extensions/CoinMachine.sol

@@ -250,6 +250,7 @@ contract CoinMachine is ColonyExtension, BasicMetaTransaction {
 
     require(ERC20(token).transfer(msgSender(), numTokens), "coin-machine-transfer-failed");
 
+    // slither-disable-next-line reentrancy-unlimited-gas
     emit TokensBought(msgSender(), token, numTokens, totalCost);
   }
 

package.json

@@ -43,7 +43,7 @@
     "test:contracts:watch": "npm run start:blockchain:client & truffle migrate --reset --compile-all && truffle watch --network development",
     "test:contracts:e2e": "npm run start:blockchain:client & truffle migrate --reset --compile-all && truffle test test-system/end-to-end.js --network development",
     "test:contracts:smoke": "truffle compile && truffle test ./test-smoke/colony-storage-consistent.js --network storageSmoke",
-    "test:security:slither": "slither . --solc-disable-warnings --exclude-low --exclude-informational --exclude-optimization --exclude uninitialized-state-variables,uninitialized-local-variables --filter-paths 'lib|contracts/testHelpers'",
+    "test:security:slither": "slither . --solc-disable-warnings --exclude-low --exclude-informational --exclude-optimization --filter-paths 'lib|contracts/testHelpers'",
     "test:security:mythril": "truffle run verify --mode quick --style json --limit 1 --swc-blacklist 101,123,128,131 > truffle-security-output.json; sed -i '/^\\[{/!d' ./truffle-security-output.json && node ./scripts/process-truffle-security.js",
     "pretest:contracts": "sed -ie \"s/eth-gas-reporter/mocha-circleci-reporter/g\" ./truffle.js && rimraf ./truffle.jse",
     "pretest:contracts:upgrade:parity": "sed -ie \"s/eth-gas-reporter/mocha-circleci-reporter/g\" ./truffle.js && rimraf ./truffle.jse",

slither.config.json

@@ -1,5 +1,5 @@
 {
-  "detectors_to_exclude": "unused-state,naming-convention,solc-version,external-function,pragma,constable-states",
+  "detectors_to_exclude": "unused-state,naming-convention,solc-version,external-function,pragma,constable-states,missing-inheritance,unintialized-state,assembly,boolean-equal,costly-loop,low-level-calls,missing-inheritance,similar-names,too-many-digits,uninitialized-state-variables,uninitialized-local-variables",
   "solc_args": "--allow-paths .",
   "solc_disable_warnings": true
-}
+}