This repository was archived by the owner on Apr 27, 2026. It is now read-only.
ci: mend unittests - #1801
Closed
3nprob wants to merge 14 commits into
Closed
Conversation
work around cpython 3.10 incompatibility with bencoder.pyx - whtsky/bencoder.pyx#143
added 3 commits
September 24, 2025 09:49
PyQt5 uses legacy license spec https://setuptools.pypa.io/en/latest/history.html#v69-0-0
This reverts commit 9d5c321.
3nprob
marked this pull request as ready for review
September 24, 2025 11:33
Author
|
See #1802 for a proper fix. |
3nprob
marked this pull request as draft
September 27, 2025 01:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work around Cython v3 incompatibility with bencoder.pyx by running on ubuntu-22.04/python3.11 alongside failing ubuntu-latest (24.04/python3.13) and macos-13 (python3.13)
Also hold back setuptools to address error:
https://github.com/JoinMarket-Org/joinmarket-clientserver/actions/runs/17972772646/job/51119109741?pr=1801
And a few other (hopefully temporary) workarounds to make CI unittests run. Set
fail-fast: falseto allow all jobs in the matrix to run despite some failing.This is less than ideal as a solution since it reduces targeted coverage and is less flexible with python versions.
But should still be a vast improvement over status quo of the tests not running at all and de-facto zero coverage?