chore: make clippy happy

Author: Jon-Becker

crates/cfg/src/core/mod.rs

@@ -1,24 +1,14 @@
 pub(crate) mod graph;
 
-
 use ethers::types::H160;
 use eyre::eyre;
 use heimdall_common::{
-    ether::{
-        bytecode::get_bytecode_from_target,
-        compiler::{detect_compiler},
-        evm::core::vm::VM,
-    },
-    utils::{
-        strings::{StringExt},
-        threading::run_with_timeout,
-    },
+    ether::{bytecode::get_bytecode_from_target, compiler::detect_compiler, evm::core::vm::VM},
+    utils::{strings::StringExt, threading::run_with_timeout},
 };
 
 use petgraph::{dot::Dot, Graph};
-use std::{
-    time::{Duration, Instant},
-};
+use std::time::{Duration, Instant};
 
 use super::CFGArgs;
 

crates/cfg/src/interfaces/function.rs

@@ -1,15 +1,11 @@
-use std::{collections::HashMap};
-
+use std::collections::HashMap;
 
 use ethers::types::U256;
 use heimdall_common::ether::{
-    evm::{
-        core::{log::Log, opcodes::WrappedOpcode},
-    },
+    evm::core::{log::Log, opcodes::WrappedOpcode},
     signatures::{ResolvedError, ResolvedFunction, ResolvedLog},
 };
 
-
 /// The [`AnalyzedFunction`] struct represents a function that has been analyzed by the decompiler.
 #[derive(Clone, Debug)]
 pub struct AnalyzedFunction {

crates/cfg/src/interfaces/mod.rs

@@ -3,4 +3,3 @@ mod function;
 
 // re-export the public interface
 pub use args::{CFGArgs, CFGArgsBuilder};
-

crates/common/src/ether/calldata.rs

@@ -1,6 +1,4 @@
-
-
-use super::rpc::{get_transaction};
+use super::rpc::get_transaction;
 use crate::{
     constants::{CALLDATA_REGEX, TRANSACTION_HASH_REGEX},
     utils::strings::decode_hex,

crates/decode/src/core/mod.rs

@@ -1,8 +1,6 @@
 use std::{collections::HashSet, time::Instant};
 
-use ethers::{
-    abi::{decode as decode_abi, ParamType},
-};
+use ethers::abi::{decode as decode_abi, ParamType};
 use eyre::eyre;
 use heimdall_common::{
     ether::{
@@ -12,10 +10,7 @@ use heimdall_common::{
         },
         signatures::{score_signature, ResolveSelector, ResolvedFunction},
     },
-    utils::{
-        io::{logging::TraceFactory},
-        strings::{encode_hex},
-    },
+    utils::{io::logging::TraceFactory, strings::encode_hex},
 };
 use tracing::{debug, info, trace, warn};
 

crates/decode/src/utils/mod.rs

@@ -1,9 +1,4 @@
 mod abi;
 
-
-
-
-
-
 // re-export
 pub use abi::{try_decode, try_decode_dynamic_parameter};

crates/decompile/src/core/mod.rs

@@ -8,7 +8,7 @@ use eyre::eyre;
 use heimdall_common::{
     ether::{
         bytecode::get_bytecode_from_target,
-        compiler::{detect_compiler},
+        compiler::detect_compiler,
         evm::core::vm::VM,
         selectors::{find_function_selectors, resolve_selectors},
         signatures::{score_signature, ResolvedError, ResolvedFunction, ResolvedLog},

crates/decompile/src/core/out/abi.rs

@@ -1,22 +1,16 @@
-use std::{
-    collections::HashMap,
-    time::{Instant},
-};
+use std::{collections::HashMap, time::Instant};
 
 use alloy_json_abi::{Error, Event, EventParam, Function, JsonAbi, Param, StateMutability};
 
-
-use eyre::{Result};
+use eyre::Result;
 use heimdall_common::{
     ether::signatures::{ResolvedError, ResolvedLog},
-    utils::{
-        strings::encode_hex_reduced,
-    },
+    utils::strings::encode_hex_reduced,
 };
 
 use tracing::debug;
 
-use crate::{interfaces::AnalyzedFunction};
+use crate::interfaces::AnalyzedFunction;
 
 pub fn build_abi(
     functions: Vec<AnalyzedFunction>,

crates/decompile/src/core/resolve.rs

@@ -1,12 +1,6 @@
-
-
-use crate::{interfaces::AnalyzedFunction};
-use heimdall_common::{
-    ether::{
-        signatures::{ResolvedFunction},
-    },
-};
-use tracing::{trace};
+use crate::interfaces::AnalyzedFunction;
+use heimdall_common::ether::signatures::ResolvedFunction;
+use tracing::trace;
 
 /// Given a list of potential [`ResolvedFunction`]s and a [`Snapshot`], return a list of
 /// [`ResolvedFunction`]s (that is, resolved signatures that were found on a 4byte directory) that

crates/decompile/src/interfaces/function.rs

@@ -1,17 +1,11 @@
-use std::{
-    collections::{HashMap, HashSet},
-};
-
+use std::collections::{HashMap, HashSet};
 
 use ethers::types::U256;
 use heimdall_common::ether::{
-    evm::{
-        core::{opcodes::WrappedOpcode, types::byte_size_to_type},
-    },
-    signatures::{ResolvedFunction},
+    evm::core::{opcodes::WrappedOpcode, types::byte_size_to_type},
+    signatures::ResolvedFunction,
 };
 
-
 /// The [`AnalyzedFunction`] struct represents a function that has been analyzed by the decompiler.
 #[derive(Clone, Debug)]
 pub struct AnalyzedFunction {

crates/decompile/src/utils/heuristics/arguments.rs

@@ -2,10 +2,7 @@ use std::collections::HashSet;
 
 use ethers::types::U256;
 
-use heimdall_common::ether::evm::core::{
-    types::convert_bitmask,
-    vm::State,
-};
+use heimdall_common::ether::evm::core::{types::convert_bitmask, vm::State};
 use tracing::{debug, trace};
 
 use crate::{
@@ -36,10 +33,10 @@ pub fn argument_heuristic(
                     arg_index, state.last_instruction.inputs[0]
                 );
                 CalldataFrame {
-                        arg_op: state.last_instruction.input_operations[0].to_string(),
-                        mask_size: 32, // init to 32 because all CALLDATALOADs are 32 bytes
-                        heuristics: HashSet::new(),
-                    }
+                    arg_op: state.last_instruction.input_operations[0].to_string(),
+                    mask_size: 32, // init to 32 because all CALLDATALOADs are 32 bytes
+                    heuristics: HashSet::new(),
+                }
             });
         }
 

crates/decompile/src/utils/heuristics/events.rs

@@ -1,17 +1,8 @@
-
-
 use ethers::{abi::AbiEncode, types::U256};
-use eyre::{OptionExt};
-use heimdall_common::ether::evm::core::{
-    vm::State,
-};
-
+use eyre::OptionExt;
+use heimdall_common::ether::evm::core::vm::State;
 
-use crate::{
-    core::analyze::AnalyzerState,
-    interfaces::{AnalyzedFunction},
-    Error,
-};
+use crate::{core::analyze::AnalyzerState, interfaces::AnalyzedFunction, Error};
 
 pub fn event_heuristic(
     function: &mut AnalyzedFunction,

crates/decompile/src/utils/heuristics/mod.rs

@@ -1,5 +1,3 @@
-
-
 use heimdall_common::ether::evm::core::vm::State;
 
 use crate::{core::analyze::AnalyzerState, interfaces::AnalyzedFunction, Error};

crates/decompile/src/utils/heuristics/solidity.rs

@@ -1,20 +1,13 @@
-
-
 use ethers::{
     abi::{decode, AbiEncode, ParamType},
     types::U256,
 };
 use eyre::eyre;
 use heimdall_common::{
-    ether::evm::core::{
-        opcodes::{WrappedOpcode},
-        types::{byte_size_to_type},
-        vm::State,
-    },
+    ether::evm::core::{opcodes::WrappedOpcode, types::byte_size_to_type, vm::State},
     utils::strings::{decode_hex, encode_hex_reduced},
 };
 
-
 use crate::{
     core::analyze::AnalyzerState,
     interfaces::{AnalyzedFunction, StorageFrame},

crates/decompile/src/utils/heuristics/yul.rs

@@ -1,7 +1,5 @@
 use eyre::eyre;
-use heimdall_common::ether::evm::core::{
-    vm::State,
-};
+use heimdall_common::ether::evm::core::vm::State;
 
 use crate::{core::analyze::AnalyzerState, interfaces::AnalyzedFunction, Error};