Skip to content

Commit fdb88eb

Browse files
committed
features: add deploy.yml, adjusting image path and fixing overlay bug
1 parent 2102298 commit fdb88eb

3 files changed

Lines changed: 51 additions & 10 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
name: Deploy static content to Pages
2+
3+
on:
4+
push:
5+
branches: ["main"]
6+
workflow_dispatch:
7+
8+
permissions:
9+
contents: read
10+
pages: write
11+
id-token: write
12+
13+
concurrency:
14+
group: "pages"
15+
cancel-in-progress: false
16+
17+
jobs:
18+
deploy:
19+
environment:
20+
name: github-pages
21+
url: ${{ steps.deployment.outputs.page_url }}
22+
runs-on: ubuntu-latest
23+
24+
steps:
25+
- name: Checkout
26+
uses: actions/checkout@v4
27+
28+
- name: Setup Pages
29+
uses: actions/configure-pages@v5
30+
31+
- name: Upload artifact
32+
uses: actions/upload-pages-artifact@v3
33+
with:
34+
path: .
35+
36+
- name: Deploy to GitHub Pages
37+
id: deployment
38+
uses: actions/deploy-pages@v4

index.html

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<head>
55
<meta charset="UTF-8" />
66
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
7-
<title>Document</title>
7+
<title>Portfolio - Jonathan Putra</title>
88
<link rel="stylesheet" href="style.css" />
99
<link rel="preconnect" href="https://fonts.googleapis.com" />
1010
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
@@ -148,7 +148,7 @@ <h2>CERTIFICATE</h2>
148148
<section id="about" class="about-carousel">
149149
<div class="carousel">
150150
<div class="about-slide active" style="
151-
background-image: url(&quot;/assets/about-background.png&quot;);
151+
background-image: url('./assets/about-background.png');
152152
">
153153
<div class="about-slide-content">
154154
<h1>BIOGRAPHY</h1>
@@ -160,7 +160,7 @@ <h3>
160160
</div>
161161
</div>
162162

163-
<div class="about-slide career-slide" style="background-image: url(&quot;/assets/about-2.png&quot;)">
163+
<div class="about-slide career-slide" style="background-image: url('./assets/about-2.png')">
164164
<div class="about-slide-content">
165165
<h1>CAREER DIRECTION</h1>
166166
<h3>
@@ -173,7 +173,7 @@ <h3>
173173
</div>
174174
</div>
175175

176-
<div class="about-slide" style="background-image: url(&quot;/assets/about-3.png&quot;)">
176+
<div class="about-slide" style="background-image: url('./assets/about-3.png')">
177177
<div class="about-slide-content">
178178
<h1>PROFESSIONAL EXPERIENCE</h1>
179179
<h3>
@@ -185,7 +185,7 @@ <h3>
185185
</div>
186186
</div>
187187

188-
<div class="about-slide" style="background-image: url(&quot;/assets/about-4.jpg&quot;)">
188+
<div class="about-slide" style="background-image: url('./assets/about-4.jpg')">
189189
<div class="about-slide-content">
190190
<h1>EDUCATION</h1>
191191
<h3>
@@ -195,7 +195,7 @@ <h3>
195195
</div>
196196
</div>
197197

198-
<div class="about-slide" style="background-image: url(&quot;/assets/about-5.png&quot;)">
198+
<div class="about-slide" style="background-image: url('./assets/about-5.png')">
199199
<div class="about-slide-content">
200200
<h1>PROJECTS</h1>
201201
<h3>
@@ -518,7 +518,7 @@ <h2>Event Recommendation System</h2>
518518

519519
<button class="project-thumb" type="button" data-full="./assets/EventHunters/HomePageResult2.png"
520520
data-alt="Event detail screen" aria-selected="false">
521-
<img src="/assets/EventHunters/HomePageResult2.png" alt="" />
521+
<img src="./assets/EventHunters/HomePageResult2.png" alt="" />
522522
<span>Event Categories</span>
523523
</button>
524524

style.css

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77
* { min-width: 0; }
88
p, h1, h2, h3, span { overflow-wrap: anywhere; }
99

10-
html, body { overflow-x: clip; }
10+
html, body {
11+
overflow-x: clip;
12+
background: #070d1c;
13+
}
1114

1215

1316
body {
@@ -304,7 +307,7 @@ body {
304307
.education-bg {
305308
position: absolute;
306309
inset: 0;
307-
background-image: url('/assets/education-background.jpg');
310+
background-image: url('./assets/education-background.jpg');
308311
background-size: cover;
309312
background-position: center;
310313
filter: blur(6px) saturate(1.08);
@@ -985,7 +988,7 @@ body {
985988
.overlay-backdrop {
986989
position: absolute;
987990
inset: 0;
988-
background: rgba(8, 14, 30, 0.45);
991+
background: rgba(8, 14, 30, 0.62);
989992
backdrop-filter: blur(8px);
990993
}
991994

0 commit comments

Comments
 (0)