Fix bug with find_do_peak(delay_b) kwarg
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
lisaprigolovkin
force-pushed
the
DO_delayb_bug
branch
from
a25d55f to
5621fec
Compare
lisaprigolovkin
force-pushed
the
DO_delayb_bug
branch
from
5621fec to
b6489fa
Compare
lisaprigolovkin
force-pushed
the
DO_delayb_bug
branch
from
b6489fa to
daffd76
Compare
Co-authored-by: Luisa Wachtendonk<[email protected]>
michaelosthege
force-pushed
the
DO_delayb_bug
branch
from
daffd76 to
34321a5
Compare
michaelosthege
changed the title
find_do_peak(delay_b) kwarg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the DO peak detection the delay_b for the DO overshoot was not fulfilled. Tests checking for the initial_delay, delay_a and delay_b were implemented. The i_overshoot was returned even if the set time of delay_b had not proceeded leading to the detection of the DO peak. To fix this, a second if clause needed to be implemented checking for the fulfillment of the proceeded time being larger than the delay_b and only then returning and detecting the correspondive DO peak.