Fix order and type conversion of fluidics["reservoir"] column
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was introduced in #67 and released in v1.4.2 (2024-06-18).
michaelosthege
force-pushed
the
fix-fluidics-source-conversion-bug
branch
from
82303c2 to
e47d6fe
Compare
michaelosthege
changed the title
fluidics["reservoir"] was brokenfluidics["reservoir"] column
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 11 11
Lines 1248 1248
=======================================
Hits 1168 1168
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was introduced in #67
and released in v1.4.2 (2024-06-18).
The conversion of all enum columns (of which there were only
fluidics["reservoir"]) totally mixed-up the order because assignment of a series into a dataframe takes the index into account.Therefore the index had to be set on the series!