Closed
Conversation
JuliaLang/julia#43852 will improve inference making it realize that `_zero(::Missing)` throws such that `_sum` can never return `missing`, breaking the inference test below because the return type is more precise than expected.
3 tasks
Member
|
Close/reopen to trigger CI. It had disabled due to lack of activity, see MappedArrays.jl/.github/workflows/CI.yml Lines 7 to 8 in 46bf47f |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 85.38% 85.60% +0.22%
==========================================
Files 1 1
Lines 130 132 +2
==========================================
+ Hits 111 113 +2
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Oops, duplicated in #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#43852 will improve inference making it
realize that
_zero(::Missing)throws such that_sumcan never returnmissing,breaking the inference test below because the return type is more precise than expected.