Skip to content

Commit 39c1132

Browse files
committed
Update docs for blackmanharris and flattop
1 parent 78cbbe6 commit 39c1132

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

src/windows.jl

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -468,15 +468,19 @@ Blackman-Harris window of length `n` with `padding` zeros. The Blackman-Harris
468468
window is a linear combination of three or four trigonometric terms, optimized
469469
for minimum sidelobe level (at the expense of a wider main lobe). The number of
470470
terms can be selected with `term` ∈ [3,4]. For `term = 3`, the maximum sidelobe
471-
level is about -69 dB, while for `term = 4` (the default), it improves to -92
472-
dB.
471+
level is about -70.83 dB, while for `term = 4` (the default), it improves to
472+
-92.01 dB. Note, that Nuttall proved those coefficients to not be the most
473+
optimized ones in [Nuttall, A. H. (1981). Some windows with very good sidelobe
474+
behavior. IEEE Transactions on Acoustics, Speech, Signal Processing, 29,
475+
84-91](https://ieeexplore.ieee.org/document/1163506).
476+
473477
474478
The 3-term window `w3(x)` and the 4-term window `w4(x)` are defined by sampling
475479
the following continuous functions in the range `[-0.5, 0.5]`:
476480
477-
w3(x) = 0.42323 + 0.49755*cos(2pi*x) + 0.07922*cos(4pi*x)
481+
w3(x) = 0.42323 + 0.49755*cos(*x) + 0.07922*cos(*x)
478482
479-
w4(x) = 0.35875 + 0.48829*cos(2pi*x) + 0.14128*cos(4pi*x) + 0.01168*cos(6pi*x)
483+
w4(x) = 0.35875 + 0.48829*cos(*x) + 0.14128*cos(*x) + 0.01168*cos(*x)
480484
481485
For more details see [Harris, F. J. (1978). On the Use of Windows for Harmonic
482486
Analysis with the Discrete Fourier Transform. Proceedings of the IEEE, 66(1),
@@ -486,9 +490,9 @@ The `blackmanharris` windows do not generally satisfy the Constant Overlap-Add
486490
(COLA) property. Nevertheless, when using `zerophase = true` and implementing the
487491
following boundary conditions they approximately do:
488492
- For the 3-term window the overlap should be 66% and the window length should
489-
be a power of 3.
493+
be a multiple of 3.
490494
- For the 4-term window the overlap should be 75% and the window length should
491-
be a power of 2.
495+
be a multiple of 2.
492496
493497
$(twoD_docs())
494498
@@ -557,7 +561,7 @@ lobe with sidelobe suppression of about 91 dB.
557561
558562
The window is defined by sampling the continuous function:
559563
560-
w3(x) = a0 + a1*cos(2pi*x) + a2*cos(4pi*x) + a3*cos(6pi*x) + a4*cos(8pi*x)
564+
w3(x) = a0 + a1*cos(*x) + a2*cos(*x) + a3*cos(*x) + a4*cos(*x)
561565
562566
in the range `[-0.5, 0.5]` with the following coefficients:
563567

0 commit comments

Comments
 (0)