Handle Base.hypot with more than 2 arguments #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Sep 29, 2025
Co-authored-by: David Müller-Widmann <[email protected]>
Contributor
Author
|
Thanks for the suggestions @devmotion. The CI errors seems to be consistent with, e.g., the most recently merged commit. But the new hypot tests in base.jl seem to have passed. |
devmotion
reviewed
Sep 30, 2025
| test_rrule(merge, (; a=1.0), (; a=2.0)) | ||
| end | ||
|
|
||
| @testset "hypot(x, y, z, xs...)" begin |
Member
There was a problem hiding this comment.
Can you also add tests with mixed Real/Complex inputs?
Contributor
Author
There was a problem hiding this comment.
Updated to test mixed inputs. The new tests are passing; CI failures are the same as before.
devmotion
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are rules for
hypot(x)andhypot(x, y), butBasedefineshypot(x, y, xs...), which is not handled by ChainRules. The two-argument case is infastmath_able, butBase.FastMathonly supports the two-argument method, so this PR adds separate forward and reverse rules specifically for 3 arguments, with aVarargon the end, to handle the remaining possibilities. These new rules are just mild generalizations of the two-argument rules.