Fix tests by using tag types instead of instances #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Makes sense to me |
Member
Author
|
Can you approve? GitHub doesn't allow me to merge the PR without approval 🙂 |
mcabbott
approved these changes
Sep 9, 2025
devmotion
added a commit
that referenced
this pull request
Sep 12, 2025
devmotion
added a commit
that referenced
this pull request
Sep 12, 2025
devmotion
added a commit
that referenced
this pull request
Sep 14, 2025
* Bump actions/cache from 1 to 3 (#643) Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix tests by using tag types instead of instances (#768) * Fix gradient and Jacobian for functions with `Dual` output (#770) * Fix gradient and Jacobian for functions with `Dual` output * Bump version from 1.2.0 to 1.2.1 * Make tests compatible with Julia 1.0 and 1.6 * Bump version to 0.10.39 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in some tests currently tag instances are used as type parameters of
Dualnumbers, even though ForwardDiff is based on using tag types. Changing tests from tag instances to tag types seems to fix a few broken tests.Edit: It seems actually this PR fixes all broken tests, on the latest commit on master CI showed 20 broken tests (e.g. https://github.com/JuliaDiff/ForwardDiff.jl/actions/runs/17241011162/job/48917940673#step:6:144) whereas on this PR CI shows no broken tests anymore (https://github.com/JuliaDiff/ForwardDiff.jl/actions/runs/17444517109/job/49535515574#step:6:165).