Fix gradient and Jacobian for functions with Dual output
#770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
force-pushed
the
dw/valtype
branch
from
ee76095 to
4986cd9
Compare
devmotion
force-pushed
the
dw/valtype
branch
from
4986cd9 to
47adb2c
Compare
andreasnoack
approved these changes
Sep 12, 2025
Member
andreasnoack
left a comment
andreasnoack
left a comment
There was a problem hiding this comment.
The change here seems right to me, and it fixes a world bug that showed up when differentiating through an ODE. The actual change is very small, and there is good test coverage.
devmotion
added a commit
that referenced
this pull request
Sep 12, 2025
devmotion
added a commit
that referenced
this pull request
Sep 12, 2025
devmotion
added a commit
that referenced
this pull request
Sep 12, 2025
devmotion
added a commit
that referenced
this pull request
Sep 14, 2025
* Bump actions/cache from 1 to 3 (#643) Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix tests by using tag types instead of instances (#768) * Fix gradient and Jacobian for functions with `Dual` output (#770) * Fix gradient and Jacobian for functions with `Dual` output * Bump version from 1.2.0 to 1.2.1 * Make tests compatible with Julia 1.0 and 1.6 * Bump version to 0.10.39 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769 by adding and using a new
valtype(::Type{T}, x)that returnstypeof(value(T, x)).The PR builds on #768 since the tests of
valtype(::Type{T}, x)require the use of tag types (not instances as on master).