Backport #770 to ForwardDiff 0.10 #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/cache](https://github.com/actions/cache) from 1 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v1...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
devmotion
force-pushed
the
dw/backport_770
branch
from
8914db4 to
9eabcb2
Compare
devmotion
force-pushed
the
dw/backport_770
branch
from
9eabcb2 to
55ba55d
Compare
andreasnoack
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently stuck with ForwardDiff 0.10 in a downstream package, but I'm running into the error that was fixed by #770.
Therefore I propose to backport the fix in #770 to the release branch for ForwardDiff 0.10 and to tag a new ForwardDiff 0.10 release.
I cherry-picked 463e830. Additionally, to make tests pass locally I also had to backport the test fix in #768 (c15deda) as otherwise tests of
valtype(T, x)fail.Edit: To make CI pass, I had also to backport #643 (actions/cache v1 is deprecated by now) and replace Julia syntax (
only->firstand[x;;]->fill(x, 1, 1): 169b7f0) in the tests of #770 that is not supported in Julia 1.0 and Julia 1.6