-
Notifications
You must be signed in to change notification settings - Fork 2
Description
From #22 :
We have a problematic interaction with minimal_period and complete_orbit. minimal_period enforces that the Δt for continuous time is T/100. How can the user control this? In general, why does minimal_period call complete_orbit in the first place? This seems unnecessary. The minimal period has the same points as the "double" or "triple" period. Once we have estimated the minimal T we don't have to recompute/re-complete the orbit. We can just create a PeriodicOrbit type with the new minimal T and reuse its .points field.
User can control it when constructing PeriodicOrbit but not inside minimal_period. A keyword argument should be added to minimal_period as well. The orbit is recomputed so that .points field contains the orbit only once and not several times.