Add diag argument to copytri! (#679)

Author: eschnett

.buildkite/pipeline.yml

@@ -47,6 +47,7 @@ steps:
         julia:
           - "1.10"
           - "1.12"
+          - "1.13"
     soft_fail:
       - exit_status: 3
 
@@ -99,6 +100,7 @@ steps:
         julia:
           - "1.10"
           - "1.12"
+          - "1.13"
     soft_fail:
       - exit_status: 3
 
@@ -151,6 +153,7 @@ steps:
         julia:
           - "1.10"
           - "1.12"
+          - "1.13"
     soft_fail:
       - exit_status: 3
 
@@ -203,6 +206,7 @@ steps:
         julia:
           - "1.10"
           - "1.12"
+          - "1.13"
     soft_fail:
       - exit_status: 3
 

.github/workflows/Test.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        version: ['1.10', '1.11', '1.12', 'nightly']
+        version: ['1.10', '1.11', '1.12', '1.13-nightly', 'nightly']
         os: [ubuntu-latest, macOS-latest, windows-latest]
     steps:
       - uses: actions/checkout@v6
@@ -97,7 +97,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
-          version: '1.11'
+          version: '1.12'
       - uses: julia-actions/cache@v2
       - name: Run tests
         run: |

src/host/linalg.jl

@@ -107,48 +107,48 @@ end
 
 ## copy upper triangle to lower and vice versa
 
-function LinearAlgebra.copytri!(A::AbstractGPUMatrix, uplo::AbstractChar, conjugate::Bool=false)
-  n = LinearAlgebra.checksquare(A)
-  if uplo == 'U' && conjugate
-      @kernel function U_conj!(_A)
-        I = @index(Global, Cartesian)
-        i, j = Tuple(I)
-        if j > i
-          @inbounds _A[j,i] = conj(_A[i,j])
+function LinearAlgebra.copytri!(A::AbstractGPUMatrix, uplo::AbstractChar, conjugate::Bool = false, diag::Bool = false)
+    n = LinearAlgebra.checksquare(A)
+    if uplo == 'U' && conjugate
+        @kernel function U_conj!(_A)
+            I = @index(Global, Cartesian)
+            i, j = Tuple(I)
+            if j + diag > i
+                @inbounds _A[j,i] = conj(_A[i,j])
+          end
         end
-      end
-      U_conj!(get_backend(A))(A; ndrange = size(A))
-  elseif uplo == 'U' && !conjugate
-      @kernel function U_noconj!(_A)
-        I = @index(Global, Cartesian)
-        i, j = Tuple(I)
-        if j > i
-          @inbounds _A[j,i] = _A[i,j]
+        U_conj!(get_backend(A))(A; ndrange = size(A))
+    elseif uplo == 'U' && !conjugate
+        @kernel function U_noconj!(_A)
+            I = @index(Global, Cartesian)
+            i, j = Tuple(I)
+            if j + diag > i
+                @inbounds _A[j,i] = _A[i,j]
+          end
         end
-      end
-      U_noconj!(get_backend(A))(A; ndrange = size(A))
-  elseif uplo == 'L' && conjugate
-      @kernel function L_conj!(_A)
-        I = @index(Global, Cartesian)
-        i, j = Tuple(I)
-        if j > i
-          @inbounds _A[i,j] = conj(_A[j,i])
+        U_noconj!(get_backend(A))(A; ndrange = size(A))
+    elseif uplo == 'L' && conjugate
+        @kernel function L_conj!(_A)
+            I = @index(Global, Cartesian)
+            i, j = Tuple(I)
+            if j + diag > i
+                @inbounds _A[i,j] = conj(_A[j,i])
+            end
         end
-      end
-      L_conj!(get_backend(A))(A; ndrange = size(A))
-  elseif uplo == 'L' && !conjugate
-      @kernel function L_noconj!(_A)
-        I = @index(Global, Cartesian)
-        i, j = Tuple(I)
-        if j > i
-          @inbounds _A[i,j] = _A[j,i]
+        L_conj!(get_backend(A))(A; ndrange = size(A))
+    elseif uplo == 'L' && !conjugate
+        @kernel function L_noconj!(_A)
+            I = @index(Global, Cartesian)
+            i, j = Tuple(I)
+            if j + diag > i
+                @inbounds _A[i,j] = _A[j,i]
+            end
         end
-      end
-      L_noconj!(get_backend(A))(A; ndrange = size(A))
-  else
-      throw(ArgumentError("uplo argument must be 'U' (upper) or 'L' (lower), got $uplo"))
-  end
-  A
+        L_noconj!(get_backend(A))(A; ndrange = size(A))
+    else
+        throw(ArgumentError("uplo argument must be 'U' (upper) or 'L' (lower), got $uplo"))
+    end
+    A
 end
 
 ## copy a triangular part of a matrix to another matrix

test/testsuite/linalg.jl

@@ -75,15 +75,15 @@
 
     @testset "triangular" begin
         @testset "copytri!" begin
-            @testset for eltya in (Float32, Float64, ComplexF32, ComplexF64), uplo in ('U', 'L'), conjugate in (true, false)
+            @testset for eltya in (Float32, Float64, ComplexF32, ComplexF64), uplo in ('U', 'L'), conjugate in (true, false), diag in (true, false)
                 if !(eltya in eltypes)
                     continue
                 end
                 n = 128
                 areal = randn(n,n)/2
                 aimg  = randn(n,n)/2
                 a = convert(Matrix{eltya}, eltya <: Complex ? complex.(areal, aimg) : areal)
-                @test compare(x -> LinearAlgebra.copytri!(x, uplo, conjugate), AT, a)
+                @test compare(x -> LinearAlgebra.copytri!(x, uplo, conjugate, diag), AT, a)
             end
         end