Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the MakieCore package from 0.5.1, 0.6, 0.7.1, 0.8 to 0.5.1, 0.6, 0.7.1, 0.8, 0.9 for package GeoInterfaceMakie.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@visr visr force-pushed the compathelper/new_version/2025-01-14-01-05-02-063-00266984713 branch from 0d9db44 to 88c8205 Compare January 14, 2025 01:05
@asinghvi17
Copy link
Member

Scatter failed for multipoint

@evetion
Copy link
Member

evetion commented Jan 14, 2025

All tests seem to be failing on

   Evaluated: 
"Point{false, false}((1, 2), crs = EPSG{1}((4326,)))"
==
"Point{false, false}((1, 2), crs = EPSG:4326)"

The {1} is a change in GFT (mine), but is this triggered by the (changed?) show method of GeoInterface with a crs?

@asinghvi17
Copy link
Member

https://github.com/JuliaGeo/GeoInterface.jl/blob/2244667db99f5fb0de2aad4de4eb069eadc2ebd7/src/wrappers.jl#L189C69-L189C103 would indicate that it is. Now CRS is shown as repr(MIME("text/plain"), crs) - which omits the string markers that it should probably have.

@asinghvi17
Copy link
Member

Anyway, GeoInterfaceMakie tests now seem to pass (I removed the one that should have been broken anyway, multipoint) so I'm happy with merging this.

@rafaqz rafaqz closed this Jan 20, 2025
@rafaqz rafaqz reopened this Jan 20, 2025
@asinghvi17 asinghvi17 merged commit 5d6b358 into main Jan 21, 2025
15 of 19 checks passed
@asinghvi17 asinghvi17 deleted the compathelper/new_version/2025-01-14-01-05-02-063-00266984713 branch January 21, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants