Improve implementation of has_ghost_vertices and is_boundary_node#240
Improve implementation of has_ghost_vertices and is_boundary_node#240DanielVandH wants to merge 6 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 94.87% 94.90% +0.02%
==========================================
Files 102 102
Lines 10370 10422 +52
==========================================
+ Hits 9839 9891 +52
Misses 531 531 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is great, thanks for looking into this. This PR: so roughly 20% faster. |
|
Hm. That's something, I suppose. I wonder what else could be done to cut the time down. Will have to give it a think, although I think technically (?) this addresses the possible fault mentioned in your original issue... I do know where a lot of performance issues currently are - it's in the representation of triangles. I had a v2 branch some time ago that aimed to solve a big performance issue (you can see what I had in mind here https://github.com/JuliaGeometry/DelaunayTriangulation.jl/blob/v2/NEWS.md) but I ran into some issue that I can't exactly recall now, and I ran out of time to really delve into it halfway through. Would love to return to that sometime. |
No description provided.