Move GeoInterface.jl to an extension#263
Conversation
|
I dropped Julia 1.6 and set the minimum compat to 1.10, so that extensions work |
|
The documenter issue is just xvfb, not this PR: |
|
I reran the doc build, seems to pass. |
|
Thank you! <3 |
|
I think registrator should be fine? At least I have never had that experience. This isn't actually breaking, all the functionality still exists, it's just in an extension now. The only potentially breaking thing might be people using And better to do that in a patch release so folks can use older versions of GB on older versions of Julia |
|
Yeah, accessing internals like that is their problem. I think this shouldn't be breaking. |
Revives #212 but for more recent changes here
Removing the GeoInterface dependency is actually crucial to simplifying GeoInterface plotting dependencies and Makie 0.24, because currently GeoInterface cant extend anything that depends on GeometryBasics.jl because of the circularity (i.e. it will break precompilation).
(there is some chance there will be circularity between extensions somewhere anyway after this, but lets deal with that later, and avoid the more drastic #260 option for now)
@SimonDanisch this is the start of getting rid of GeoInterfaceMakie.jl ;)