Skip to content

Commit 43772c2

Browse files
committed
Test for undocumented names, update docs
1 parent 44c907e commit 43772c2

File tree

8 files changed

+30
-7
lines changed

8 files changed

+30
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ All notable changes to this project since V1.0 will be documented in this file.
99
The RawTetGenIO based API is not affected. Users who
1010
rely on the RawTetGenIO based API can use `TetGen="1,2"`
1111
in their `[compat]` section.
12+
- Breaking: remove deprecated `tetunsuitable`. Use `tetunsuitable!` instead
1213

1314
## [1.5.1] - 2024-02-27
1415

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Plotted with Makie:
6464
```julia
6565
using TetGen
6666
let
67-
tetunsuitable() do pa,pb,pc,pd
67+
tetunsuitable!() do pa,pb,pc,pd
6868
vol=det(hcat(pb-pa,pc-pa,pd-pa))/6
6969
center=0.25*(pa+pb+pc+pd)-[0.5,0.5,0.5]
7070
vol> 0.05*norm(center)^2.5

docs/make.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ function make_all()
44
makedocs(;
55
sitename = "TetGen.jl",
66
modules = [TetGen],
7-
warnonly = true,
87
clean = false,
98
doctest = false,
109
authors = "Simon Danisch, Juergen Fuhrmann",

docs/src/index.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ Modules = [TetGen]
1414
Pages = ["api.jl"]
1515
```
1616

17+
18+
1719
## Raw API
1820
This API is closer to TetGen's C++ API in the sense that
1921
input and output are described using arrays of integers
@@ -40,3 +42,8 @@ tetunsuitable!
4042
Link to preprint [here](http://doi.org/10.20347/WIAS.PREPRINT.1762).
4143

4244

45+
## Internal API
46+
```@autodocs
47+
Modules = [TetGen]
48+
Pages = ["meshes.jl", "jltetgenio.jl", "cpptetgenio.jl"]
49+
```

src/TetGen.jl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
"""
2+
TetGen
3+
4+
$(read(joinpath(@__DIR__,"..","README.md"),String))
5+
"""
16
module TetGen
27
using DocStringExtensions: DocStringExtensions, SIGNATURES, TYPEDEF,
38
TYPEDFIELDS, TYPEDSIGNATURES
@@ -17,7 +22,7 @@ include("meshes.jl")
1722
include("api.jl")
1823

1924
export tetrahedralize
20-
export tetunsuitable!, tetunsuitable
25+
export tetunsuitable!
2126
export TetGenError
2227
export RawTetGenIO, facetlist!, RawFacet
2328
export numberofpoints, numberoftetrahedra, numberoftrifaces, numberofedges

src/api.jl

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""
2-
$(SIGNATURES)
2+
voronoi(points::Vector{Point{3, T}}) where {T <: AbstractFloat}
33
44
Create voronoi diagram of point set.
55
@@ -14,7 +14,14 @@ end
1414
$(SIGNATURES)
1515
1616
Tetrahedralize a mesh of polygons with optional facet markers.
17-
Returns a mesh of tetrahdra.
17+
Returns a mesh of tetrahdra.
18+
19+
With `GeometryBasics` version 0.4, the input mesh has to be a `GeometryBasics.Mesh` with
20+
possible metadata. With `GeometryBasics` version 0.5, the input mesh has to be a `GeometryBasics.MetaMesh`.
21+
22+
Default command is "Qp", creating the Delaunay
23+
triangulation of the point set. See the list of
24+
possible flags in the documentation of [`tetrahedralize(::RawTetGenIO, flags)`](@ref).
1825
"""
1926
function TetGen.tetrahedralize(mesh, command = "Qp";
2027
marker = :markers, holes = Point{3, Float64}[])

src/cpptetgenio.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,5 +149,3 @@ function tetunsuitable!(unsuitable::Function; check_signature = true)
149149
c_wrap_tetunsuitable = @cfunction(jl_wrap_tetunsuitable, Cint, (Ptr{Cdouble}, Ptr{Cdouble}, Ptr{Cdouble}, Ptr{Cdouble}))
150150
ccall((:tetunsuitable_callback, libtet), Cvoid, (Ptr{Cvoid},), c_wrap_tetunsuitable)
151151
end
152-
153-
@deprecate tetunsuitable(unsuitable::Function; kwargs...) tetunsuitable!(unsuitable::Function; kwargs...)

test/runtests.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,3 +287,9 @@ end
287287
@testset "Aqua" begin
288288
Aqua.test_all(TetGen)
289289
end
290+
291+
if isdefined(Docs, :undocumented_names)
292+
@testset "UndocumentedNames" begin
293+
@test isempty(Docs.undocumented_names(TetGen))
294+
end
295+
end

0 commit comments

Comments
 (0)