Skip to content

Commit ad4b1ae

Browse files
committed
Remove +(Point3, Point3)
1 parent 0d3506c commit ad4b1ae

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

docs/src/releases.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- Upgraded to CxxWrap version 0,17
66
- Fixes:
77
- #37 Removed from exports the ones clashing with `Base`: "length", "size", "angle", "decompose", "contains"
8+
- Fix type piracy in Transformation3D.jl (removed +(Point3, Point3)). It was breaking Makie 0.24
89

910
### 0.2.2 - 20-June-2025
1011
- New Features:

ext/G4Vis/Transformation3D.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Base.:*(x::Vector3, n::Number) = Vector3(x[1]*n, x[2]*n, x[3]*n)
99
Base.:*(n::Number, x::Vector3) = x * n
1010
Base.:/(p::Point3, n::Number) = Point3(p[1]/n, p[2]/n, p[3]/n)
1111
LinearAlgebra.:(x::Vector3, y::Vector3) = x[1]*y[1] + x[2]*y[2] + x[3]*y[3]
12-
Base.:-(p1::Point3, p2::Point3) = Vector3(p1[1]-p2[1], p1[2]-p2[2], p1[3]-p2[3])
13-
Base.:+(p1::Point3, p2::Point3) = Vector3(p1[1]+p2[1], p1[2]+p2[2], p1[3]+p2[3])
12+
#Base.:-(p1::Point3, p2::Point3) = Vector3(p1[1]-p2[1], p1[2]-p2[2], p1[3]-p2[3])
13+
#Base.:+(p1::Point3, p2::Point3) = Vector3(p1[1]+p2[1], p1[2]+p2[2], p1[3]+p2[3])
1414
LinearAlgebra.:×(x::Vector3, y::Vector3) = Vector3(x[2]*y[3]-x[3]*y[2], -x[1]*y[3]+x[3]*y[1], x[1]*y[2]-x[2]*y[1])
1515
unitize(v::Vector3) = v/sqrt(vv)
1616

0 commit comments

Comments
 (0)