-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
The return values from the jet selectors are incorrect, as they create a LorentzVectorCyl, but use the rapidity in place of pseudo rapidity:
JetReconstruction.jl/src/ClusterSequence.jl
Line 268 in 79cee14
| LorentzVectorCyl(pt(jet), rapidity(jet), phi(jet), mass(jet))) |
and
JetReconstruction.jl/src/ClusterSequence.jl
Line 360 in 79cee14
| LorentzVectorCyl(pt(jet), rapidity(jet), phi(jet), mass(jet))) |
This needs to be fixed to use correctly the eta(jet).
This has gone unnoticed because in the constructor for FinalJet from a LorentzVectorCyl the pseudo rapidity was taken and used as if it were the rapidity,
JetReconstruction.jl/src/Utils.jl
Lines 132 to 133 in 79cee14
| FinalJet(LorentzVectorHEP.eta(jet), LorentzVectorHEP.phi(jet), | |
| LorentzVectorHEP.pt(jet))) |
which turned out to be the workflow for all of the unit tests.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working