Conversation
|
I think you can define an empty function HTTPStream endin the base package, and extend it in the extension package https://github.com/JuliaHEP/Minuit2.jl/blob/9b2eea06693853fb720118a64d8de16b13dd80a0/ext/Minuit2PlotsExt.jl#L15 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 84.41% 84.32% -0.09%
==========================================
Files 21 23 +2
Lines 3099 3107 +8
==========================================
+ Hits 2616 2620 +4
- Misses 483 487 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I yeah, that's probably the easiest |
|
Hmm, that will not work: ERROR: LoadError: cannot assign a value to imported variable UnROOTHTTPExt.HTTPStream |
|
Ah OK, I know what to do. I will convert that to actual function calls... |
|
OK, this will work. Ready @Moelf We could then do 0.11 because it's breaking. |
|
I will also add a README entry for the breaking change ;) |
The only part which I am stuck at right now is in
src/root.jl:since both
HTTPStreamandXRDStreamare defined in extensions, which causes a problem of course.The question is then: how to deal with a type-matching based on string value with potentially undefined types.
For now I went with a symbol-based dynamic approach (which fails, but I will have a look asap):